[llvm] [AArch64] Allow single-element vector FP converts with +fprcvt (PR #169692)

[via llvm-commits]

https://github.com/Lukacma commented:

Thank you for the patch ! It is good to finally have this feature guards set properly. I am confused by couple of things though regarding this patch and would appreciate if you could clarify them. 

Firstly, what is the scope of this patch ? In the description you mention fixing fp to int patterns, but you also fix some int to fp ones ? In any case you missed v1f16 fp to int patterns starting on line 6823 . You also missed patterns introduced as part of the instruction definition on line 6520 onwards. If. you are also fixing int to fp in this patch, there are some patterns missed there as well.

Secondly, this is not your mistake but the testing of the updated patterns is incomplete. The tests added do not cover all the patterns with updated feature flags. Lot of them are still untested in streaming or streaming compatible mode. Considering the previous patch didn't contain them as well, maybe its fine not have them here though. Maybe @CarolineConcatto or @sdesmalen-arm can clarify this.



https://github.com/llvm/llvm-project/pull/169692