[llvm] [AMDGPU] Remove unused functions isSigned. NFC (PR #169750)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 26 17:02:18 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-amdgpu
Author: Jim Lin (tclin914)
<details>
<summary>Changes</summary>
These have been unused since
https://github.com/llvm/llvm-project/pull/145483.
---
Full diff: https://github.com/llvm/llvm-project/pull/169750.diff
1 Files Affected:
- (modified) llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp (-18)
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
index 8e35ba77d69aa..71ea9ef6fc050 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUCodeGenPrepare.cpp
@@ -143,14 +143,6 @@ class AMDGPUCodeGenPrepareImpl
bool canBreakPHINode(const PHINode &I);
- /// \returns True if binary operation \p I is a signed binary operation, false
- /// otherwise.
- bool isSigned(const BinaryOperator &I) const;
-
- /// \returns True if the condition of 'select' operation \p I comes from a
- /// signed 'icmp' operation, false otherwise.
- bool isSigned(const SelectInst &I) const;
-
/// Return true if \p T is a legal scalar floating point type.
bool isLegalFloatingTy(const Type *T) const;
@@ -304,16 +296,6 @@ bool AMDGPUCodeGenPrepareImpl::run() {
return MadeChange;
}
-bool AMDGPUCodeGenPrepareImpl::isSigned(const BinaryOperator &I) const {
- return I.getOpcode() == Instruction::AShr ||
- I.getOpcode() == Instruction::SDiv || I.getOpcode() == Instruction::SRem;
-}
-
-bool AMDGPUCodeGenPrepareImpl::isSigned(const SelectInst &I) const {
- return isa<ICmpInst>(I.getOperand(0)) &&
- cast<ICmpInst>(I.getOperand(0))->isSigned();
-}
-
bool AMDGPUCodeGenPrepareImpl::isLegalFloatingTy(const Type *Ty) const {
return Ty->isFloatTy() || Ty->isDoubleTy() ||
(Ty->isHalfTy() && ST.has16BitInsts());
``````````
</details>
https://github.com/llvm/llvm-project/pull/169750
More information about the llvm-commits
mailing list