[llvm] [Offloading] Extend OffloadBinary format to support multiple metadata entries (PR #169425)

[via llvm-commits]

github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

The build failed before running any tests. Click on a failure below to see the details.

<details>
<summary>lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/OffloadWrapper.cpp.o</summary>

```
FAILED: lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/OffloadWrapper.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/Frontend/Offloading -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/Offloading -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/OffloadWrapper.cpp.o -MF lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/OffloadWrapper.cpp.o.d -o lib/Frontend/Offloading/CMakeFiles/LLVMFrontendOffloading.dir/OffloadWrapper.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/Offloading/OffloadWrapper.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Frontend/Offloading/OffloadWrapper.cpp:164:46: error: no member named 'EntryOffset' in 'llvm::object::OffloadBinary::Header'
164 |               Binary.bytes_begin() + Header->EntryOffset);
|                                      ~~~~~~  ^
1 error generated.
```
</details>
<details>
<summary>lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/OffloadEmitter.cpp.o</summary>

```
FAILED: lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/OffloadEmitter.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/ObjectYAML -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/ObjectYAML -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/OffloadEmitter.cpp.o -MF lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/OffloadEmitter.cpp.o.d -o lib/ObjectYAML/CMakeFiles/LLVMObjectYAML.dir/OffloadEmitter.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/ObjectYAML/OffloadEmitter.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/ObjectYAML/OffloadEmitter.cpp:49:18: error: no member named 'EntryOffset' in 'llvm::object::OffloadBinary::Header'
49 |       TheHeader->EntryOffset = *Doc.EntryOffset;
|       ~~~~~~~~~  ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/ObjectYAML/OffloadEmitter.cpp:51:18: error: no member named 'EntrySize' in 'llvm::object::OffloadBinary::Header'
51 |       TheHeader->EntrySize = *Doc.EntrySize;
|       ~~~~~~~~~  ^
2 errors generated.
```
</details>
<details>
<summary>lib/Object/CMakeFiles/LLVMObject.dir/OffloadBinary.cpp.o</summary>

```
FAILED: lib/Object/CMakeFiles/LLVMObject.dir/OffloadBinary.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/Object -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Object/CMakeFiles/LLVMObject.dir/OffloadBinary.cpp.o -MF lib/Object/CMakeFiles/LLVMObject.dir/OffloadBinary.cpp.o.d -o lib/Object/CMakeFiles/LLVMObject.dir/OffloadBinary.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:192:18: error: no member named 'EntryOffset' in 'llvm::object::OffloadBinary::Header'
192 |   if (TheHeader->EntryOffset > TheHeader->Size - sizeof(Entry) ||
|       ~~~~~~~~~  ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:193:18: error: no member named 'EntrySize' in 'llvm::object::OffloadBinary::Header'
193 |       TheHeader->EntrySize > TheHeader->Size - sizeof(Header))
|       ~~~~~~~~~  ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:197:57: error: no member named 'EntryOffset' in 'llvm::object::OffloadBinary::Header'
197 |       reinterpret_cast<const Entry *>(&Start[TheHeader->EntryOffset]);
|                                              ~~~~~~~~~  ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:230:13: error: no member named 'EntryOffset' in 'llvm::object::OffloadBinary::Header'
230 |   TheHeader.EntryOffset = sizeof(Header);
|   ~~~~~~~~~ ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:231:13: error: no member named 'EntrySize' in 'llvm::object::OffloadBinary::Header'
231 |   TheHeader.EntrySize = sizeof(Entry);
|   ~~~~~~~~~ ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Object/OffloadBinary.cpp:253:66: error: missing field 'ValueSize' initializer [-Werror,-Wmissing-field-initializers]
253 |                     Offset + StrTab.getOffset(KeyAndValue.second)};
|                                                                  ^
6 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/169425