[llvm] [cmake] Fix semicolon expansion when passing LLVM_TABLEGEN_FLAGS (PR #169518)

Anton Sidorenko via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 25 08:36:33 PST 2025


https://github.com/asi-sc created https://github.com/llvm/llvm-project/pull/169518

This patch uses common workaround for cmake semicolon expansion to spaces

>From 0d7044dbb3111b9d577006404cdb19de314bfcd8 Mon Sep 17 00:00:00 2001
From: Anton Sidorenko <anton.sidorenko at mail.com>
Date: Tue, 25 Nov 2025 17:46:42 +0300
Subject: [PATCH] [cmake] Fix incorrect semicolon expansion when passing
 LLVM_TABLEGEN_FLAGS

---
 llvm/cmake/modules/CrossCompile.cmake | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/llvm/cmake/modules/CrossCompile.cmake b/llvm/cmake/modules/CrossCompile.cmake
index 2a69c5133c56f..6075e6abdde74 100644
--- a/llvm/cmake/modules/CrossCompile.cmake
+++ b/llvm/cmake/modules/CrossCompile.cmake
@@ -69,6 +69,8 @@ function(llvm_create_cross_target project_name target_name toolchain buildtype)
          "${LLVM_EXTERNAL_PROJECTS}")
   string(REPLACE ";" "$<SEMICOLON>" llvm_enable_runtimes_arg
          "${LLVM_ENABLE_RUNTIMES}")
+  string(REPLACE ";" "$<SEMICOLON>" llvm_tablegen_flags
+         "${LLVM_TABLEGEN_FLAGS}")
 
   set(external_project_source_dirs)
   foreach(project ${LLVM_EXTERNAL_PROJECTS})
@@ -100,7 +102,7 @@ function(llvm_create_cross_target project_name target_name toolchain buildtype)
         -DLLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN="${LLVM_TEMPORARILY_ALLOW_OLD_TOOLCHAIN}"
         -DLLVM_INCLUDE_BENCHMARKS=OFF
         -DLLVM_INCLUDE_TESTS=OFF
-        -DLLVM_TABLEGEN_FLAGS="${LLVM_TABLEGEN_FLAGS}"
+        -DLLVM_TABLEGEN_FLAGS="${llvm_tablegen_flags}"
         -DPYTHON_EXECUTABLE="${PYTHON_EXECUTABLE}"
         ${build_type_flags} ${linker_flag} ${external_clang_dir} ${libc_flags}
         ${ARGN}



More information about the llvm-commits mailing list