[llvm] [AMDGPU] Remove isKernelLDS, add isKernel(const Function &). NFC. (PR #167300)

via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 25 03:56:56 PST 2025


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 3053 tests passed
* 7 tests skipped

All tests passed but another part of the build **failed**. Click on a failure below to see the details.

<details>
<summary>lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerExecSync.cpp.o</summary>

```
FAILED: lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerExecSync.cpp.o
sccache /opt/llvm/bin/clang++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/lib/Target/AMDGPU -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU -I/home/gha/actions-runner/_work/llvm-project/llvm-project/build/include -I/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/include -gmlt -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wstring-conversion -Wno-pass-failed -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerExecSync.cpp.o -MF lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerExecSync.cpp.o.d -o lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPULowerExecSync.cpp.o -c /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:47:11: error: use of undeclared identifier 'isKernelLDS'; did you mean 'isKernel'?
47 |       if (isKernelLDS(F) && F != KF) {
|           ^~~~~~~~~~~
|           isKernel
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:23: note: 'isKernel' declared here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:47:23: error: cannot initialize a parameter of type 'CallingConv::ID' (aka 'unsigned int') with an lvalue of type 'Function *'
47 |       if (isKernelLDS(F) && F != KF) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:48: note: passing argument to parameter 'CC' here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:64:12: error: use of undeclared identifier 'isKernelLDS'; did you mean 'isKernel'?
64 |       if (!isKernelLDS(F) || F == KF) {
|            ^~~~~~~~~~~
|            isKernel
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:23: note: 'isKernel' declared here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:64:24: error: cannot initialize a parameter of type 'CallingConv::ID' (aka 'unsigned int') with an lvalue of type 'Function *'
64 |       if (!isKernelLDS(F) || F == KF) {
|                        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:48: note: passing argument to parameter 'CC' here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:136:12: error: use of undeclared identifier 'isKernelLDS'; did you mean 'isKernel'?
136 |     assert(isKernelLDS(F));
|            ^~~~~~~~~~~
|            isKernel
/usr/include/assert.h:103:27: note: expanded from macro 'assert'
103 |      (static_cast <bool> (expr)                                         \
|                           ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:23: note: 'isKernel' declared here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:136:24: error: cannot initialize a parameter of type 'CallingConv::ID' (aka 'unsigned int') with an lvalue of type 'Function *'
136 |     assert(isKernelLDS(F));
|                        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:48: note: passing argument to parameter 'CC' here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:172:12: error: use of undeclared identifier 'isKernelLDS'; did you mean 'isKernel'?
172 |     assert(isKernelLDS(K.first));
|            ^~~~~~~~~~~
|            isKernel
/usr/include/assert.h:103:27: note: expanded from macro 'assert'
103 |      (static_cast <bool> (expr)                                         \
|                           ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:23: note: 'isKernel' declared here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:172:24: error: cannot initialize a parameter of type 'CallingConv::ID' (aka 'unsigned int') with an lvalue of type 'llvm::Function *'
172 |     assert(isKernelLDS(K.first));
|                        ^~~~~~~
/usr/include/assert.h:103:27: note: expanded from macro 'assert'
103 |      (static_cast <bool> (expr)                                         \
|                           ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:48: note: passing argument to parameter 'CC' here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                                                ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:194:12: error: use of undeclared identifier 'isKernelLDS'; did you mean 'isKernel'?
194 |     assert(isKernelLDS(F));
|            ^~~~~~~~~~~
|            isKernel
/usr/include/assert.h:103:27: note: expanded from macro 'assert'
103 |      (static_cast <bool> (expr)                                         \
|                           ^~~~
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:23: note: 'isKernel' declared here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                       ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/AMDGPULowerExecSync.cpp:194:24: error: cannot initialize a parameter of type 'CallingConv::ID' (aka 'unsigned int') with an lvalue of type 'Function *'
194 |     assert(isKernelLDS(F));
|                        ^
/home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/lib/Target/AMDGPU/Utils/AMDGPUBaseInfo.h:1507:48: note: passing argument to parameter 'CC' here
1507 | constexpr inline bool isKernel(CallingConv::ID CC) {
|                                                ^
10 errors generated.
```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/167300


More information about the llvm-commits mailing list