[llvm] [AArch64] Assert `expandMOVImm` prioritizes optimal single MOVZ/N (PR #169341)
Tomer Shafir via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 24 07:32:26 PST 2025
https://github.com/tomershafir updated https://github.com/llvm/llvm-project/pull/169341
>From ab50da96f619e5f31706b4f654329b474b0aebf3 Mon Sep 17 00:00:00 2001
From: tomershafir <tomer.shafir8 at gmail.com>
Date: Mon, 24 Nov 2025 17:32:03 +0200
Subject: [PATCH] [AArch64] Assert `expandMOVImm` prioritizes optimal single
MOVZ/N
The expansion of move immediate in `expandMOVImm` follows the priority of the `MOV` alias. In addition, the selection there properly prefers expansion based on perf optimality order. This change adds a simple assert that `expandMOVImmSimple` expands a single optimal MOVZ/MOVK.
---
llvm/lib/Target/AArch64/AArch64ExpandImm.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/llvm/lib/Target/AArch64/AArch64ExpandImm.cpp b/llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
index e9660ac140301..ae5818419cba5 100644
--- a/llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ExpandImm.cpp
@@ -549,6 +549,8 @@ void AArch64_IMM::expandMOVImm(uint64_t Imm, unsigned BitSize,
// Prefer MOVZ/MOVN over ORR because of the rules for the "mov" alias.
if ((BitSize / 16) - OneChunks <= 1 || (BitSize / 16) - ZeroChunks <= 1) {
expandMOVImmSimple(Imm, BitSize, OneChunks, ZeroChunks, Insn);
+ assert(Insn.size() == 1 &&
+ "Move of immediate should have expanded to a single MOVZ/MOVN");
return;
}
More information about the llvm-commits
mailing list