[llvm] [AMDGPU][gfx1250] Add wait_xcnt before any access that cannot be repeated (PR #168852)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 21 05:16:42 PST 2025


================
@@ -9934,6 +9934,11 @@ void SIInstrInfo::fixImplicitOperands(MachineInstr &MI) const {
   }
 }
 
+bool SIInstrInfo::isVBUFFER(const MachineInstr &MI) const {
+  return (ST.getGeneration() == GCNSubtarget::GFX12) &&
----------------
jayfoad wrote:

I would prefer to have the isGFX12 check done in SIMemoryLegalizer, right next to the FIXME comment that explains why we need it. Then this helper function can become a generation-independent `isBUF`.

Also nit: you don't need the parens.

https://github.com/llvm/llvm-project/pull/168852


More information about the llvm-commits mailing list