[llvm] [ORC] Free ELF debug objects in dealloc action of corresponding code (wip) (PR #168522)

[Lang Hames via llvm-commits]

Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>,
Stefan =?utf-8?q?Gränitz?= <stefan.graenitz at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/168522 at github.com>


================
@@ -413,129 +177,165 @@ ELFDebugObjectPlugin::ELFDebugObjectPlugin(ExecutionSession &ES,
       AutoRegisterCode(AutoRegisterCode) {
   // Pass bootstrap symbol for registration function to enable debugging
   ErrorAsOutParameter _(&Err);
-  Err = ES.getExecutorProcessControl().getBootstrapSymbols(
-      {{RegistrationAction, rt::RegisterJITLoaderGDBAllocActionName}});
+  Err = ES.getExecutorProcessControl().getBootstrapSymbols({
+      {RegistrationAction, rt::RegisterJITLoaderGDBAllocActionName},
+      {DeallocAction, rt::SimpleExecutorMemoryManagerReleaseWrapperName},
+      {TargetMemMgr, rt::SimpleExecutorMemoryManagerInstanceName},
----------------
lhames wrote:

I think that that sounds reasonable, but we should wait until we've brought up the new ORC runtime: there might be an opportunity to define a widely implementable set of memory allocation primitives there.

https://github.com/llvm/llvm-project/pull/168522