[llvm] [GitHub] Add review instructions for commit access requests (PR #168971)

[Ellis Hoag via llvm-commits]

https://github.com/ellishg created https://github.com/llvm/llvm-project/pull/168971

As discussed in https://discourse.llvm.org/t/clarification-on-how-to-accept-commit-access-requests/88728, clarify reviewer instructions for how to accept commit access requests.

>From eb2bd42b84466687a826b2cdf31332dff2f69d25 Mon Sep 17 00:00:00 2001
From: Ellis Hoag <ellishoag at meta.com>
Date: Thu, 20 Nov 2025 15:44:35 -0800
Subject: [PATCH] [GitHub] Add review instructions for commit access requests

---
 llvm/docs/DeveloperPolicy.rst       | 5 ++++-
 llvm/utils/git/github-automation.py | 2 ++
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/llvm/docs/DeveloperPolicy.rst b/llvm/docs/DeveloperPolicy.rst
index 9135406c2e2a1..72663cbdb79a1 100644
--- a/llvm/docs/DeveloperPolicy.rst
+++ b/llvm/docs/DeveloperPolicy.rst
@@ -526,7 +526,10 @@ Most commonly these reviewers will provide the necessary approval, but approvals
 from other LLVM committers are also acceptable. Those reviewing the application are
 confirming that you have indeed had three patches committed, and that based on interactions
 on those reviews and elsewhere in the LLVM community they have no concern about you
-adhering to our Developer Policy and Code of Conduct.
+adhering to our Developer Policy and Code of Conduct. Reviewers should clearly state their
+reasoning for accepting or rejecting the request, and finish with a clear statement such
+as "I approve of this request" or "I do not approve of this request".
+
 
 If approved, a GitHub invitation will be sent to your
 GitHub account. In case you don't get notification from GitHub, go to
diff --git a/llvm/utils/git/github-automation.py b/llvm/utils/git/github-automation.py
index 948788d501d1d..e68f99fc2aad6 100755
--- a/llvm/utils/git/github-automation.py
+++ b/llvm/utils/git/github-automation.py
@@ -305,6 +305,8 @@ def run(self) -> bool:
             * [{merged_prs} Merged Pull Requests]({merged_prs_url})
             * Top 3 Committers: {get_user_values_str(get_top_values(merged_by))}
             * Top 3 Reviewers: {get_user_values_str(get_top_values(reviewed_by))}
+
+            Reviewers should clearly state their reasoning for accepting or rejecting this request, and finish with a clear statement such as \"I approve of this request\" or \"I do not approve of this request\". Please review the instructions for [obtaining commit access](https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access).
         """
         self.issue.create_comment(textwrap.dedent(comment))