[llvm] [SPIRV] Enable DCE in instruction selection and update tests (PR #168428)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 20 09:28:00 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
index d43a92113..f9ddb3efd 100644
--- a/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
+++ b/llvm/lib/Target/SPIRV/SPIRVInstructionSelector.cpp
@@ -650,8 +650,9 @@ bool isDead(const MachineInstr &MI, const MachineRegisterInfo &MRI) {
return true;
}
- // It is possible that the only side effect is that the instruction is referenced in the
- // global registry. If that is the only side effect, the intrinsic is dead.
+ // It is possible that the only side effect is that the instruction is
+ // referenced in the global registry. If that is the only side effect, the
+ // intrinsic is dead.
if (MI.getOpcode() == TargetOpcode::G_INTRINSIC_W_SIDE_EFFECTS ||
MI.getOpcode() == TargetOpcode::G_INTRINSIC_CONVERGENT_W_SIDE_EFFECTS) {
const auto &Intr = cast<GIntrinsic>(MI);
``````````
</details>
https://github.com/llvm/llvm-project/pull/168428
More information about the llvm-commits
mailing list