[llvm] Add more missing `LLVM_ABI` annotations (PR #168765)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 19 11:59:56 PST 2025


================
@@ -898,19 +869,9 @@ class VPIRFlags {
     return DisjointFlags.IsDisjoint;
   }
 
-private:
-  /// Get a reference to the fast-math flags for FPMathOp or FCmp.
-  FastMathFlagsTy &getFMFsRef() {
-    return OpType == OperationType::FCmp ? FCmpFlags.FMFs : FMFs;
-  }
-  const FastMathFlagsTy &getFMFsRef() const {
-    return OpType == OperationType::FCmp ? FCmpFlags.FMFs : FMFs;
-  }
-
-public:
 #if !defined(NDEBUG)
   /// Returns true if the set flags are valid for \p Opcode.
-  bool flagsValidForOpcode(unsigned Opcode) const;
+  LLVM_ABI_FOR_TEST bool flagsValidForOpcode(unsigned Opcode) const;
----------------
fhahn wrote:

Why is this needed? `flagsValidForOpcode` isn't used for `llvm/unittests`, I thought that `LLVM_ABI_FOR_TEST` was needed for function called from there?

https://github.com/llvm/llvm-project/pull/168765


More information about the llvm-commits mailing list