[llvm] [LV] Use VPReductionRecipe for partial reductions (PR #147513)

Florian Hahn via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 18 07:21:48 PST 2025


================
@@ -8184,11 +8185,21 @@ VPRecipeBase *VPRecipeBuilder::tryToCreateWidenRecipe(VPSingleDefRecipe *R,
              Phi->getIncomingValueForBlock(OrigLoop->getLoopPreheader()));
 
       // If the PHI is used by a partial reduction, set the scale factor.
+      bool UseInLoopReduction = CM.isInLoopReduction(Phi);
+      bool UseOrderedReductions = CM.useOrderedReductions(RdxDesc);
       unsigned ScaleFactor =
           getScalingForReduction(RdxDesc.getLoopExitInstr()).value_or(1);
-      PhiRecipe = new VPReductionPHIRecipe(
-          Phi, RdxDesc.getRecurrenceKind(), *StartV, CM.isInLoopReduction(Phi),
-          CM.useOrderedReductions(RdxDesc), ScaleFactor);
+      RdxStyle Style(RdxNormal{});
----------------
fhahn wrote:

nit: 
```suggestion
      RdxStyle Style(RdxNormal());
```

I think generally `()` is used to call constructors instead of `{}`, not sure if there's a benefit of using `{}`?

https://github.com/llvm/llvm-project/pull/147513


More information about the llvm-commits mailing list