[clang] [llvm] [HLSL][SPIR-V] Implement vk::push_constant (PR #166793)

[via llvm-commits]

Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>,
Nathan =?utf-8?q?Gauër?= <brioche at google.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/166793 at github.com>


github-actions[bot] wrote:

<!--PREMERGE ADVISOR COMMENT: Linux-->
# :penguin: Linux x64 Test Results

* 166079 tests passed
* 2838 tests skipped
* 1 test failed

## Failed Tests
(click on a test name to see its output)

### LLVM
<details>
<summary>LLVM.CodeGen/SPIRV/vk-pushconstant-access.ll</summary>

```
Exit Code: 1

Command Output (stdout):
--
# RUN: at line 1
/home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll -o - | /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll -o -
# note: command had no output on stdout or stderr
# executed command: /home/gha/actions-runner/_work/llvm-project/llvm-project/build/bin/FileCheck /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll
# .---command stderr------------
# | /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll:10:14: error: CHECK-DAG: expected string not found in input
# | ; CHECK-DAG: %[[#S_S]] = OpTypeStruct %[[#F32]]
# |              ^
# | <stdin>:1:1: note: scanning from here
# |  OpCapability Shader
# | ^
# | <stdin>:1:1: note: with "S_S" equal to "4"
# |  OpCapability Shader
# | ^
# | <stdin>:1:1: note: with "F32" equal to "4"
# |  OpCapability Shader
# | ^
# | <stdin>:19:3: note: possible intended match here
# |  %8 = OpTypeStruct %4
# |   ^
# | 
# | Input file: <stdin>
# | Check file: /home/gha/actions-runner/_work/llvm-project/llvm-project/llvm/test/CodeGen/SPIRV/vk-pushconstant-access.ll
# | 
# | -dump-input=help explains the following input dump.
# | 
# | Input was:
# | <<<<<<
# |           1:  OpCapability Shader 
# | dag:10'0     X~~~~~~~~~~~~~~~~~~~~ error: no match found
# | dag:10'1                           with "S_S" equal to "4"
# | dag:10'2                           with "F32" equal to "4"
# |           2:  OpMemoryModel Logical GLSL450 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           3:  OpEntryPoint GLCompute %13 "main" %12 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           4:  OpExecutionMode %13 LocalSize 1 1 1 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           5:  OpSource Unknown 0 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~
# |           6:  OpName %13 "main" 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~
# |           .
# |           .
# |           .
# |          14:  %3 = OpTypeFunction %2 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~
# |          15:  %4 = OpTypeFloat 32 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~
# |          16:  %5 = OpTypePointer PushConstant %4 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          17:  %6 = OpTypePointer Function %4 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          18:  %7 = OpTypeInt 32 0 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~
# |          19:  %8 = OpTypeStruct %4 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~
# | dag:10'3       ?                    possible intended match
# |          20:  %9 = OpTypeStruct %4 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~
# |          21:  %10 = OpTypePointer PushConstant %9 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          22:  %11 = OpConstant %7 0 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~
# |          23:  %12 = OpVariable %10 PushConstant  
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |          24:  %13 = OpFunction %2 DontInline %3 ; -- Begin function main 
# | dag:10'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# |           .
# |           .
# |           .
# | >>>>>>
# `-----------------------------
# error: command failed with exit status: 1

--

```
</details>

If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the `infrastructure` label.

https://github.com/llvm/llvm-project/pull/166793