[llvm] [GlobalMerge]Prefer use global-merge-max-offset instead of the target-specific constant offset. (PR #165591)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 15 17:40:50 PST 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/GlobalMerge.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/GlobalMerge.cpp b/llvm/lib/CodeGen/GlobalMerge.cpp
index 0f398b375..bb7fd622d 100644
--- a/llvm/lib/CodeGen/GlobalMerge.cpp
+++ b/llvm/lib/CodeGen/GlobalMerge.cpp
@@ -765,8 +765,9 @@ Pass *llvm::createGlobalMergePass(const TargetMachine *TM, unsigned Offset,
bool MergeConstAggressive = GlobalMergeAllConst.getNumOccurrences() > 0
? GlobalMergeAllConst
: MergeConstAggressiveByDefault;
- unsigned PreferOffset = GlobalMergeMaxOffset.getNumOccurrences() > 0 ?
- GlobalMergeMaxOffset : Offset;
+ unsigned PreferOffset = GlobalMergeMaxOffset.getNumOccurrences() > 0
+ ? GlobalMergeMaxOffset
+ : Offset;
return new GlobalMerge(TM, PreferOffset, OnlyOptimizeForSize, MergeExternal,
MergeConstant, MergeConstAggressive);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/165591
More information about the llvm-commits
mailing list