[llvm] CodeGen: Remove TRI arguments from stack load/store hooks (PR #158240)

Prabhu Rajasekaran via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 11 09:01:22 PST 2025


Prabhuk wrote:

This patch seems to have missed CSKYSubtarget. Seeing failures in our builders.
https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/rust_llvm-linux-arm64/b8698533035513747057/overview

```
[2187/3156] Building CXX object lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o
FAILED: [code=1] lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o 
/b/s/w/ir/x/w/clang++_cfg_aarch64-unknown-linux-gnu_wrapper -DGTEST_HAS_RTTI=0 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/b/s/w/ir/x/w/staging/build/fuchsia-build/aarch64-unknown-linux-gnu/llvm/build/lib/Target/M68k -I/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k -I/b/s/w/ir/x/w/staging/build/fuchsia-build/aarch64-unknown-linux-gnu/llvm/build/include -I/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/include -ffunction-sections -fdata-sections -fPIC --target=aarch64-unknown-linux-gnu -I/b/s/w/ir/x/w/install-zlib-aarch64-linux-gnu/include -I/b/s/w/ir/x/w/install-zstd-aarch64-linux-gnu/include --target=aarch64-unknown-linux-gnu --sysroot=/b/s/w/ir/x/w/cipd/linux --sysroot=/b/s/w/ir/x/w/cipd/linux -stdlib=libc++ -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -w -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17 -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -MD -MT lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o -MF lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o.d -o lib/Target/M68k/CMakeFiles/LLVMM68kCodeGen.dir/GISel/M68kInstructionSelector.cpp.o -c /b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/GISel/M68kInstructionSelector.cpp
In file included from /b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/GISel/M68kInstructionSelector.cpp:10:
In file included from /b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/M68kSubtarget.h:19:
/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/M68kInstrInfo.h:285:65: error: non-virtual member function marked 'override' hides virtual member function
  285 |       MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const override;
      |                                                                 ^
/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/include/llvm/CodeGen/TargetInstrInfo.h:1197:16: note: hidden overloaded virtual function 'llvm::TargetInstrInfo::storeRegToStackSlot' declared here: different number of parameters (8 vs 9)
 1197 |   virtual void storeRegToStackSlot(
      |                ^
In file included from /b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/GISel/M68kInstructionSelector.cpp:10:
In file included from /b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/M68kSubtarget.h:19:
/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/lib/Target/M68k/M68kInstrInfo.h:291:65: error: non-virtual member function marked 'override' hides virtual member function
  291 |       MachineInstr::MIFlag Flags = MachineInstr::NoFlags) const override;
      |                                                                 ^
/b/s/w/ir/x/w/fuchsia-third_party-rust/src/llvm-project/llvm/include/llvm/CodeGen/TargetInstrInfo.h:1215:16: note: hidden overloaded virtual function 'llvm::TargetInstrInfo::loadRegFromStackSlot' declared here: different number of parameters (7 vs 8)
 1215 |   virtual void loadRegFromStackSlot(
      |                ^
2 errors generated.
[
```

CC: @ilovepi 

https://github.com/llvm/llvm-project/pull/158240


More information about the llvm-commits mailing list