[llvm] [mlir] [Flang][OpenMP][Taskloop] Translation support for taskloop construct (PR #166903)

[Jack Styles via llvm-commits]

================
@@ -1933,6 +1933,205 @@ static Value *emitTaskDependencies(
   return DepArray;
 }
 
+OpenMPIRBuilder::InsertPointOrErrorTy OpenMPIRBuilder::createTaskloop(
+    const LocationDescription &Loc, InsertPointTy AllocaIP,
+    BodyGenCallbackTy BodyGenCB,
+    llvm::function_ref<llvm::Expected<llvm::CanonicalLoopInfo *>()> loopInfo,
----------------
Stylie777 wrote:

The name of `loopInfo` here does not seem to match that of the header file, this should really be `LoopInfo`. I also think we could just pass this as a pointer and an assert to check its present, if you disagree let me know.

```suggestion
    llvm::CanonicalLoopInfo * loopInfo,
    ...

    assert(loopInfo && "Expected CLI info");
```

https://github.com/llvm/llvm-project/pull/166903