[llvm] [SLP] Loop aware cost model/tree building (PR #150450)

[via llvm-commits]

github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->


:warning: undef deprecator found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/lib/Transforms/Vectorize/SLPVectorizer.cpp llvm/test/Transforms/SLPVectorizer/AArch64/getelementptr.ll llvm/test/Transforms/SLPVectorizer/AArch64/horizontal.ll llvm/test/Transforms/SLPVectorizer/AArch64/landing_pad.ll llvm/test/Transforms/SLPVectorizer/AArch64/slp-fma-loss.ll llvm/test/Transforms/SLPVectorizer/AMDGPU/vectorize-i8.ll llvm/test/Transforms/SLPVectorizer/RISCV/small-phi-tree.ll llvm/test/Transforms/SLPVectorizer/SystemZ/SLP-cmp-cost-query.ll llvm/test/Transforms/SLPVectorizer/SystemZ/vec-elt-insertion.ll llvm/test/Transforms/SLPVectorizer/X86/cse.ll llvm/test/Transforms/SLPVectorizer/X86/geps-non-pow-2.ll llvm/test/Transforms/SLPVectorizer/X86/malformed_phis.ll llvm/test/Transforms/SLPVectorizer/X86/matching-gather-nodes-phi-users.ll llvm/test/Transforms/SLPVectorizer/X86/phi.ll llvm/test/Transforms/SLPVectorizer/X86/reduced-val-extracted-and-externally-used.ll llvm/test/Transforms/SLPVectorizer/X86/reduced-val-vectorized-in-transform.ll llvm/test/Transforms/SLPVectorizer/X86/remark_horcost.ll llvm/test/Transforms/SLPVectorizer/X86/remark_not_all_parts.ll llvm/test/Transforms/SLPVectorizer/consecutive-access.ll llvm/test/Transforms/SLPVectorizer/reduced-gathered-vectorized.ll
``````````

</details>


The following files introduce new uses of undef:
 - llvm/test/Transforms/SLPVectorizer/X86/geps-non-pow-2.ll

[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.

In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.

For example, this is considered a bad practice:
```llvm
define void @fn() {
  ...
  br i1 undef, ...
}
```

Please use the following instead:
```llvm
define void @fn(i1 %cond) {
  ...
  br i1 %cond, ...
}
```

Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.



https://github.com/llvm/llvm-project/pull/150450