[llvm] [ObjectYAML] Remove extraneous .c_str() (NFC) (PR #167189)

via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 8 15:05:45 PST 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-objectyaml

Author: Kazu Hirata (kazutakahirata)

<details>
<summary>Changes</summary>

maskedBitSetCase takes StringRef, so we can "implicitly cast"
std::string to StringRef.

Identified with readability-redundant-string-cstr.


---
Full diff: https://github.com/llvm/llvm-project/pull/167189.diff


1 Files Affected:

- (modified) llvm/lib/ObjectYAML/ELFYAML.cpp (+1-1) 


``````````diff
diff --git a/llvm/lib/ObjectYAML/ELFYAML.cpp b/llvm/lib/ObjectYAML/ELFYAML.cpp
index 29f291614ffc6..d07c37edad241 100644
--- a/llvm/lib/ObjectYAML/ELFYAML.cpp
+++ b/llvm/lib/ObjectYAML/ELFYAML.cpp
@@ -670,7 +670,7 @@ void ScalarBitSetTraits<ELFYAML::ELF_EF>::bitset(IO &IO,
       for (unsigned K = ELF::EF_AMDGPU_GENERIC_VERSION_MIN;
            K <= ELF::EF_AMDGPU_GENERIC_VERSION_MAX; ++K) {
         std::string Key = "EF_AMDGPU_GENERIC_VERSION_V" + std::to_string(K);
-        IO.maskedBitSetCase(Value, Key.c_str(),
+        IO.maskedBitSetCase(Value, Key,
                             K << ELF::EF_AMDGPU_GENERIC_VERSION_OFFSET,
                             ELF::EF_AMDGPU_GENERIC_VERSION);
       }

``````````

</details>


https://github.com/llvm/llvm-project/pull/167189


More information about the llvm-commits mailing list