[llvm] [BinaryFromat] Simplify subscript operators (NFC) (PR #167170)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Sat Nov 8 11:00:07 PST 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/167170

Identified with readability-simplify-subscript-expr.


>From 494606dfb9ce9055c5aef339d4af5d42a312b368 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 6 Nov 2025 07:16:27 -0800
Subject: [PATCH] [BinaryFromat] Simplify subscript operators (NFC)

Identified with readability-simplify-subscript-expr.
---
 llvm/unittests/BinaryFormat/MsgPackWriterTest.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/unittests/BinaryFormat/MsgPackWriterTest.cpp b/llvm/unittests/BinaryFormat/MsgPackWriterTest.cpp
index 3a5ba9af08f6c..dd8826ca6ccd5 100644
--- a/llvm/unittests/BinaryFormat/MsgPackWriterTest.cpp
+++ b/llvm/unittests/BinaryFormat/MsgPackWriterTest.cpp
@@ -40,7 +40,7 @@ TEST_F(MsgPackWriter, TestWriteFixPositiveInt) {
     MPWriter.write(u);
     std::string Output = OStream.str();
     EXPECT_EQ(Output.size(), 1u);
-    EXPECT_EQ(Output.data()[0], static_cast<uint8_t>(u));
+    EXPECT_EQ(Output[0], static_cast<uint8_t>(u));
   }
 }
 
@@ -128,7 +128,7 @@ TEST_F(MsgPackWriter, TestWriteFixNegativeInt) {
     MPWriter.write(i);
     std::string Output = OStream.str();
     EXPECT_EQ(Output.size(), 1u);
-    EXPECT_EQ(static_cast<int8_t>(Output.data()[0]), static_cast<int8_t>(i));
+    EXPECT_EQ(static_cast<int8_t>(Output[0]), static_cast<int8_t>(i));
   }
 }
 



More information about the llvm-commits mailing list