[llvm] [MachinePipeliner] Detect a cycle in PHI dependencies early on (PR #167095)

via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 7 21:03:49 PST 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/MachinePipeliner.cpp --diff_from_common_commit
``````````

:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/lib/CodeGen/MachinePipeliner.cpp b/llvm/lib/CodeGen/MachinePipeliner.cpp
index b327ba890..ad6fd0d20 100644
--- a/llvm/lib/CodeGen/MachinePipeliner.cpp
+++ b/llvm/lib/CodeGen/MachinePipeliner.cpp
@@ -485,7 +485,8 @@ void MachinePipeliner::setPragmaPipelineOptions(MachineLoop &L) {
   }
 }
 
-bool hasPHICycle(const MachineBasicBlock *LoopHeader, const MachineRegisterInfo &MRI) {
+bool hasPHICycle(const MachineBasicBlock *LoopHeader,
+                 const MachineRegisterInfo &MRI) {
   DenseMap<unsigned, SmallVector<unsigned, 2>> PhiDeps;
   SmallSet<unsigned, 8> PhiRegs;
 
@@ -507,7 +508,7 @@ bool hasPHICycle(const MachineBasicBlock *LoopHeader, const MachineRegisterInfo
   SmallSet<unsigned, 8> Visited, RecStack;
 
   std::function<bool(unsigned)> DFS = [&](unsigned Reg) -> bool {
-  if (!PhiRegs.count(Reg))
+    if (!PhiRegs.count(Reg))
       return false;
     if (RecStack.count(Reg))
       return true;

``````````

</details>


https://github.com/llvm/llvm-project/pull/167095


More information about the llvm-commits mailing list