[llvm] [CI] Make premerge_advisor_explain write comments (PR #166605)

Aiden Grossman via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 7 11:24:20 PST 2025


================
@@ -33,17 +33,18 @@ function at-exit {
   # If building fails there will be no results files.
   shopt -s nullglob
 
-  if [[ "$GITHUB_STEP_SUMMARY" != "" ]]; then
+  if [[ "$GITHUB_ACTIONS" != "" ]]; then
     python "${MONOREPO_ROOT}"/.ci/generate_test_report_github.py \
       $retcode "${BUILD_DIR}"/test-results.*.xml "${MONOREPO_ROOT}"/ninja*.log \
       >> $GITHUB_STEP_SUMMARY
+    python "${MONOREPO_ROOT}"/.ci/premerge_advisor_explain.py \
+      $(git rev-parse HEAD~1) $retcode ${{ secrets.GITHUB_TOKEN }} \
----------------
boomanaiden154 wrote:

No, this was actually broken. I forgot that `${{ secrets.GITHUB_TOKEN }}` can only be expanded if it's written inside the github actions workflow file. Should be fixed, but I'll let premerge finish to confirm.

https://github.com/llvm/llvm-project/pull/166605


More information about the llvm-commits mailing list