[llvm] [Demangle] Remove redundant declarations (NFC) (PR #166895)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 6 22:15:42 PST 2025


https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/166895

In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.

Identified with readability-redundant-declaration.


>From efbc5ff02818dd841bfd9a916edb8b4d57ab941b Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Thu, 6 Nov 2025 13:40:44 -0800
Subject: [PATCH] [Demangle] Remove redundant declarations (NFC)

In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.

Identified with readability-redundant-declaration.
---
 llvm/lib/Demangle/ItaniumDemangle.cpp | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/llvm/lib/Demangle/ItaniumDemangle.cpp b/llvm/lib/Demangle/ItaniumDemangle.cpp
index 1009cc91ca12a..8e476cdafdb71 100644
--- a/llvm/lib/Demangle/ItaniumDemangle.cpp
+++ b/llvm/lib/Demangle/ItaniumDemangle.cpp
@@ -25,10 +25,6 @@
 using namespace llvm;
 using namespace llvm::itanium_demangle;
 
-constexpr const char *itanium_demangle::FloatData<float>::spec;
-constexpr const char *itanium_demangle::FloatData<double>::spec;
-constexpr const char *itanium_demangle::FloatData<long double>::spec;
-
 // <discriminator> := _ <non-negative number>      # when number < 10
 //                 := __ <non-negative number> _   # when number >= 10
 //  extension      := decimal-digit+               # at the end of string



More information about the llvm-commits mailing list