[llvm] [BPF] TableGen-erate SDNode descriptions (PR #166499)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 6 12:37:39 PST 2025
eddyz87 wrote:
> > Do you know why we do not have problems before for BR_CC/MRMCPY?
>
> SelectionDAG is very permissive about such inconsistencies. Fixing it to be more robust is my end goal.
>
> > Looks like WASM is correct and the other three need update...
>
> LanaiISD::BR_CC uses SDNPInGlue because it "glues" a comparison to the branch. In BPF comparison and branch a fused into one BPFISD::BR_CC node (same as LoongArch).
>
> ARMISD::MEMCPY is indeed incorrect in that it shouldn't have SDNPInGlue. I'm not sure if it needs an out glue, but at least its presence is consistent with C++ code.
>
> Whether or not to use glue operands/results is really target-dependent.
Ack, thank you for explaining.
https://github.com/llvm/llvm-project/pull/166499
More information about the llvm-commits
mailing list