[llvm] ad723f9 - [LLVM] Check if LLVM_ON_UNIX is Defined

[via llvm-commits]

Author: Aiden Grossman
Date: 2025-11-06T12:04:12-08:00
New Revision: ad723f940980d94ee72084571c9fb06e46659b76

URL: https://github.com/llvm/llvm-project/commit/ad723f940980d94ee72084571c9fb06e46659b76
DIFF: https://github.com/llvm/llvm-project/commit/ad723f940980d94ee72084571c9fb06e46659b76.diff

LOG: [LLVM] Check if LLVM_ON_UNIX is Defined

This is canonical in the rest of the repository and otherwise we can end
up with warnings when compiling with clang-cl on Windows that look like
the following:

```
2025-11-06T17:55:25.2412502Z C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/thread.h(37,5): warning: 'LLVM_ON_UNIX' is not defined, evaluates to 0 [-Wundef]
2025-11-06T17:55:25.2413436Z    37 | #if LLVM_ON_UNIX || _WIN32
2025-11-06T17:55:25.2413791Z       |     ^
2025-11-06T17:55:25.2414625Z C:\_work\llvm-project\llvm-project\llvm\include\llvm/Support/thread.h(52,5): warning: 'LLVM_ON_UNIX' is not defined, evaluates to 0 [-Wundef]
2025-11-06T17:55:25.2415585Z    52 | #if LLVM_ON_UNIX
2025-11-06T17:55:25.2415901Z       |     ^
2025-11-06T17:55:25.2416169Z 2 warnings generated.
```

Reviewers: joker-eph, pcc, cachemeifyoucan

Reviewed By: cachemeifyoucan

Pull Request: https://github.com/llvm/llvm-project/pull/166827

Added: 
    

Modified: 
    llvm/include/llvm/Support/thread.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/thread.h b/llvm/include/llvm/Support/thread.h
index ecde62d8368e7..51873e7d529bf 100644
--- a/llvm/include/llvm/Support/thread.h
+++ b/llvm/include/llvm/Support/thread.h
@@ -34,7 +34,7 @@ typedef PVOID HANDLE;
 
 namespace llvm {
 
-#if LLVM_ON_UNIX || _WIN32
+#if defined(LLVM_ON_UNIX) || defined(_WIN32)
 
 /// LLVM thread following std::thread interface with added constructor to
 /// specify stack size.
@@ -49,7 +49,7 @@ class thread {
   }
 
 public:
-#if LLVM_ON_UNIX
+#ifdef LLVM_ON_UNIX
   using native_handle_type = pthread_t;
   using id = pthread_t;
   using start_routine_type = void *(*)(void *);