[llvm] [DebugInfo] Fix line 0 records incorrectly having is_stmt set (PR #166627)
Orlando Cazalet-Hyams via llvm-commits
llvm-commits at lists.llvm.org
Thu Nov 6 06:27:42 PST 2025
https://github.com/OCHyams commented:
Thanks for taking a look at the issue
Please could you remove unrelated formatting changes from the patch? It adds "noise" to reviews - typically we only format lines that are touched by the patch (git diff -U0 | py -3 clang\tools\clang-format\clang-format-diff.py -p1 -binary "<path-to-llvm-build-dir>\bin\clang-format" -i).
> Test results: All 576 X86 DebugInfo tests pass.
As you're changing functionality, this patch will need to come with a/some new test/tests.
In the linked ticket it says
> There is one test related to prologue-end that seems to be testing that it's okay for prologue-end to be line 0, and I ran out of time to investigate any further.
Do you know which test that is? I wonder if there's any git-history which could be relevant
https://github.com/llvm/llvm-project/pull/166627
More information about the llvm-commits
mailing list