[llvm] [ProfCheck][NFC] Make Function argument from branch weight setter optional (PR #166032)

Wed Nov 5 09:53:36 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `bolt-aarch64-ubuntu-nfc` running on `bolt-worker-aarch64` while building `llvm` at step 7 "build-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/217/builds/1924

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 7 (build-bolt) failure: build (failure)
...
7.878 [776/34/33] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/SafepointIRVerifier.cpp.o
7.950 [775/34/34] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/DebugInfo.cpp.o
8.381 [774/34/35] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Attributes.cpp.o
8.593 [773/34/36] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Type.cpp.o
8.621 [772/34/37] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Dominators.cpp.o
8.827 [771/34/38] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CallBrPrepare.cpp.o
8.929 [770/34/39] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Instructions.cpp.o
9.007 [769/34/40] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Core.cpp.o
9.065 [768/34/41] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/LLVMContextImpl.cpp.o
9.820 [767/34/42] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/build/lib/CodeGen -I/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/llvm-project/llvm/lib/CodeGen -I/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/build/include -I/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-dangling-reference -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o -c /home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/llvm-project/llvm/lib/CodeGen/AtomicExpandPass.cpp
/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/llvm-project/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘llvm::Value* {anonymous}::AtomicExpandImpl::insertRMWLLSCLoop(llvm::IRBuilderBase&, llvm::Type*, llvm::Value*, llvm::Align, llvm::AtomicOrdering, llvm::function_ref<llvm::Value*(llvm::IRBuilderBase&, llvm::Value*)>)’:
/home/buildbot/workspace/bolt-aarch64-ubuntu-nfc/llvm-project/llvm/lib/CodeGen/AtomicExpandPass.cpp:1304:56: error: could not convert ‘* F’ from ‘llvm::Function’ to ‘llvm::StringRef’
 1304 |   setExplicitlyUnknownBranchWeightsIfProfiled(*CondBr, *F, DEBUG_TYPE);
      |                                                        ^~
      |                                                        |
      |                                                        llvm::Function
9.854 [767/33/43] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CallingConvLower.cpp.o
10.077 [767/32/44] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Value.cpp.o
10.234 [767/31/45] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Constants.cpp.o
11.268 [767/30/46] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CriticalAntiDepBreaker.cpp.o
11.300 [767/29/47] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/Analysis.cpp.o
11.340 [767/28/48] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FuncletLayout.cpp.o
11.520 [767/27/49] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandReductions.cpp.o
11.600 [767/26/50] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandLargeDivRem.cpp.o
11.923 [767/25/51] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CommandFlags.cpp.o
11.925 [767/24/52] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FaultMaps.cpp.o
12.044 [767/23/53] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DFAPacketizer.cpp.o
12.445 [767/22/54] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DwarfEHPrepare.cpp.o
12.455 [767/21/55] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AggressiveAntiDepBreaker.cpp.o
12.557 [767/20/56] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandVectorPredication.cpp.o
12.685 [767/19/57] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FinalizeISel.cpp.o
12.977 [767/18/58] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/BranchFolding.cpp.o
13.042 [767/17/59] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandMemCmp.cpp.o
13.380 [767/16/60] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExpandFp.cpp.o
13.419 [767/15/61] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AsmWriter.cpp.o
13.614 [767/14/62] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AutoUpgrade.cpp.o
13.714 [767/13/63] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/DebugInfoMetadata.cpp.o
14.418 [767/12/64] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/GCRootLowering.cpp.o
14.771 [767/11/65] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/HardwareLoops.cpp.o
14.788 [767/10/66] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ComplexDeinterleavingPass.cpp.o
14.857 [767/9/67] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/GlobalMergeFunctions.cpp.o
14.883 [767/8/68] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/GlobalMerge.cpp.o
15.455 [767/7/69] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/FixupStatepointCallerSaved.cpp.o
15.507 [767/6/70] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
15.780 [767/5/71] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/BasicTargetTransformInfo.cpp.o
16.300 [767/4/72] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/IfConversion.cpp.o
17.230 [767/3/73] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AssignmentTrackingAnalysis.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/166032