[llvm] [ProfCheck][NFC] Make Function argument from branch weight setter optional (PR #166032)

Wed Nov 5 07:46:11 PST 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `mlir-nvidia-gcc7` running on `mlir-nvidia` while building `llvm` at step 6 "build-check-mlir-build-only".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/116/builds/20583

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-check-mlir-build-only) failure: build (failure)
...
46.425 [4054/16/976] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DeadMachineInstructionElim.cpp.o
46.448 [4053/16/977] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DetectDeadLanes.cpp.o
47.812 [4052/16/978] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Value.cpp.o
47.835 [4051/16/979] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/DroppedVariableStatsMIR.cpp.o
49.966 [4050/16/980] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CallBrPrepare.cpp.o
49.993 [4049/16/981] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/EarlyIfConversion.cpp.o
50.016 [4048/16/982] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/EdgeBundles.cpp.o
50.038 [4047/16/983] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/EHContGuardTargets.cpp.o
50.061 [4046/16/984] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/ExecutionDomainFix.cpp.o
51.438 [4045/16/985] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o
FAILED: lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/g++-7 -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/lib/CodeGen -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/CodeGen -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.obj/include -I/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-array-bounds -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -MD -MT lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o -MF lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o.d -o lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AtomicExpandPass.cpp.o -c /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/CodeGen/AtomicExpandPass.cpp
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/CodeGen/AtomicExpandPass.cpp: In member function ‘llvm::Value* {anonymous}::AtomicExpandImpl::insertRMWLLSCLoop(llvm::IRBuilderBase&, llvm::Type*, llvm::Value*, llvm::Align, llvm::AtomicOrdering, llvm::function_ref<llvm::Value*(llvm::IRBuilderBase&, llvm::Value*)>)’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/CodeGen/AtomicExpandPass.cpp:1304:56: error: could not convert ‘* F’ from ‘llvm::Function’ to ‘llvm::StringRef’
   setExplicitlyUnknownBranchWeightsIfProfiled(*CondBr, *F, DEBUG_TYPE);
                                                        ^~
52.583 [4045/15/986] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CallingConvLower.cpp.o
52.669 [4045/14/987] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/AggressiveAntiDepBreaker.cpp.o
In file included from /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/CodeGen/AggressiveAntiDepBreaker.cpp:27:0:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/CodeGen/ScheduleDAG.h:321:40: warning: ‘llvm::SUnit::SchedulingPref’ is too small to hold all values of ‘enum llvm::Sched::Preference’
     Sched::Preference SchedulingPref : 4; ///< Scheduling preference.
                                        ^
53.364 [4045/13/988] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/Analysis.cpp.o
53.820 [4045/12/989] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/CommandFlags.cpp.o
54.924 [4045/11/990] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Metadata.cpp.o
In file included from /vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/lib/IR/Metadata.cpp:13:0:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DILocation]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:83:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
   template <class NodeTy> static void dispatchRecalculateHash(NodeTy *N) {
                                                                       ^
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DIExpression]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:84:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DIGlobalVariableExpression]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:85:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DISubrange]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:88:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DIEnumerator]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:89:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DIBasicType]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:92:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h: In instantiation of ‘static void llvm::MDNode::dispatchRecalculateHash(NodeTy*) [with NodeTy = llvm::DIDerivedType]’:
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.def:93:1:   required from here
/vol/worker/mlir-nvidia/mlir-nvidia-gcc7/llvm.src/llvm/include/llvm/IR/Metadata.h:1414:71: warning: parameter ‘N’ set but not used [-Wunused-but-set-parameter]

```

</details>

https://github.com/llvm/llvm-project/pull/166032