[llvm] [BOLT][NFC] Rename funtions with _negative suffix to _unknown when th… (PR #166536)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 5 03:26:07 PST 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-bolt
Author: Elvina Yakubova (ElvinaYakubova)
<details>
<summary>Changes</summary>
…e size is unknown
Keep _negative suffix only for test cases when the size is negative
---
Full diff: https://github.com/llvm/llvm-project/pull/166536.diff
1 Files Affected:
- (modified) bolt/test/runtime/AArch64/inline-memcpy.s (+15-15)
``````````diff
diff --git a/bolt/test/runtime/AArch64/inline-memcpy.s b/bolt/test/runtime/AArch64/inline-memcpy.s
index badff299603a0..75066c855b9ed 100644
--- a/bolt/test/runtime/AArch64/inline-memcpy.s
+++ b/bolt/test/runtime/AArch64/inline-memcpy.s
@@ -81,14 +81,14 @@
# CHECK-ASM: bl{{.*}}<memcpy
# Register move should NOT be inlined (size unknown at compile time)
-# CHECK-ASM-LABEL: <test_register_move_negative>:
+# CHECK-ASM-LABEL: <test_register_move_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy
-# CHECK-ASM-LABEL: <test_x2_rewrite_negative>:
+# CHECK-ASM-LABEL: <test_x2_rewrite_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy
# Live-in parameter should NOT be inlined (size unknown at compile time)
-# CHECK-ASM-LABEL: <test_live_in_negative>:
+# CHECK-ASM-LABEL: <test_live_in_unknown>:
# CHECK-ASM: bl{{.*}}<memcpy
# _memcpy8 should be inlined with end-pointer return (dest+size)
@@ -262,9 +262,9 @@ test_4_byte_add_immediate:
ret
.size test_4_byte_add_immediate, .-test_4_byte_add_immediate
- .globl test_register_move_negative
- .type test_register_move_negative, at function
-test_register_move_negative:
+ .globl test_register_move_unknown
+ .type test_register_move_unknown, at function
+test_register_move_unknown:
stp x29, x30, [sp, #-32]!
mov x29, sp
add x1, sp, #16
@@ -274,20 +274,20 @@ test_register_move_negative:
bl memcpy
ldp x29, x30, [sp], #32
ret
- .size test_register_move_negative, .-test_register_move_negative
+ .size test_register_move_unknown, .-test_register_move_unknown
- .globl test_x2_rewrite_negative
- .type test_x2_rewrite_negative, at function
-test_x2_rewrite_negative:
+ .globl test_x2_rewrite_unknown
+ .type test_x2_rewrite_unknown, at function
+test_x2_rewrite_unknown:
mov x2, #8
ldr x2, [sp, #24]
bl memcpy
ret
- .size test_x2_rewrite_negative, .-test_x2_rewrite_negative
+ .size test_x2_rewrite_unknown, .-test_x2_rewrite_unknown
- .globl test_live_in_negative
- .type test_live_in_negative, at function
-test_live_in_negative:
+ .globl test_live_in_unknown
+ .type test_live_in_unknown, at function
+test_live_in_unknown:
# x2 comes in as parameter, no instruction sets it (should NOT inline)
stp x29, x30, [sp, #-32]!
mov x29, sp
@@ -297,7 +297,7 @@ test_live_in_negative:
bl memcpy
ldp x29, x30, [sp], #32
ret
- .size test_live_in_negative, .-test_live_in_negative
+ .size test_live_in_unknown, .-test_live_in_unknown
.globl test_memcpy8_4_byte
.type test_memcpy8_4_byte, at function
``````````
</details>
https://github.com/llvm/llvm-project/pull/166536
More information about the llvm-commits
mailing list