[llvm] [VPlan] Fix first-lane comment in sinkScalarOperands (NFC) (PR #166347)

Ramkumar Ramachandra via llvm-commits llvm-commits at lists.llvm.org
Tue Nov 4 03:03:26 PST 2025


https://github.com/artagnon created https://github.com/llvm/llvm-project/pull/166347

To follow-up on a post-commit review.

>From da3d1fbc19d4fba1c8643f1c25961512e1135329 Mon Sep 17 00:00:00 2001
From: Ramkumar Ramachandra <ramkumar.ramachandra at codasip.com>
Date: Tue, 4 Nov 2025 10:48:04 +0000
Subject: [PATCH] [VPlan] Fix first-lane comment in sinkScalarOperands (NFC)

To follow-up on a post-commit review.
---
 llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
index e8e87aa8a4f3c..2588c878d8472 100644
--- a/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
+++ b/llvm/lib/Transforms/Vectorize/VPlanTransforms.cpp
@@ -198,8 +198,8 @@ static bool sinkScalarOperands(VPlan &Plan) {
     VPSingleDefRecipe *SinkCandidate;
     std::tie(SinkTo, SinkCandidate) = WorkList[I];
 
-    // All recipe users of the sink candidate must be in the same block SinkTo
-    // or all users outside of SinkTo must have only their first lane used. In
+    // All recipe users of SinkCandidate must be in the same block SinkTo or all
+    // users outside of SinkTo must only use the first lane of SinkCandidate. In
     // the latter case, we need to duplicate SinkCandidate.
     auto UsersOutsideSinkTo =
         make_filter_range(SinkCandidate->users(), [SinkTo](VPUser *U) {



More information about the llvm-commits mailing list