[llvm] [LoopUnroll] Fix division by zero (PR #166258)
Joel E. Denny via llvm-commits
llvm-commits at lists.llvm.org
Mon Nov 3 16:03:45 PST 2025
jdenny-ornl wrote:
> ¯_(ツ)_/¯ just felt like a lot of text (which to me felt like it may as easily confuse readers as it may help). Is the profile really "bad" in that case? I think having a 1:0 probability is still possible either because it's actually infinite, or because the difference is too small to represent.
You convinced me. I moved it into the function body. I reworded it to focus more on our attempt to derive a meaningful result from the probability rather than on whether it was truly wrong.
> But as I said arguing about source code comments is highly subjective, so do with my comment as you wish or ignore...
Thanks for raising it.
https://github.com/llvm/llvm-project/pull/166258
More information about the llvm-commits
mailing list