[llvm] [X86] Remove redundant declarations (NFC) (PR #166107)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sun Nov 2 14:54:45 PST 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/166107
In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.
Identified with readability-redundant-declaration.
>From 9201907a07b0d9361e6e67cc69a99fb29bc7e144 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sun, 2 Nov 2025 13:58:02 -0800
Subject: [PATCH] [X86] Remove redundant declarations (NFC)
In C++17, static constexpr members are implicitly inline, so they no
longer require an out-of-line definition.
Identified with readability-redundant-declaration.
---
llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp | 3 ---
1 file changed, 3 deletions(-)
diff --git a/llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp b/llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp
index b655183b6b49b..3b96e706fb607 100644
--- a/llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp
+++ b/llvm/lib/Target/X86/X86LoadValueInjectionLoadHardening.cpp
@@ -227,9 +227,6 @@ struct DOTGraphTraits<MachineGadgetGraph *> : DefaultDOTGraphTraits {
} // end namespace llvm
-constexpr MachineInstr *MachineGadgetGraph::ArgNodeSentinel;
-constexpr int MachineGadgetGraph::GadgetEdgeSentinel;
-
char X86LoadValueInjectionLoadHardeningPass::ID = 0;
void X86LoadValueInjectionLoadHardeningPass::getAnalysisUsage(
More information about the llvm-commits
mailing list