[compiler-rt] 206a1d2 - Revert "Reapply "[compiler-rt] Default to Lit's Internal Shell""

[Aiden Grossman via llvm-commits]

Author: Aiden Grossman
Date: 2025-11-02T18:07:29Z
New Revision: 206a1d2b5b0f7a6a7b8fdf06d067f37677bd13b1

URL: https://github.com/llvm/llvm-project/commit/206a1d2b5b0f7a6a7b8fdf06d067f37677bd13b1
DIFF: https://github.com/llvm/llvm-project/commit/206a1d2b5b0f7a6a7b8fdf06d067f37677bd13b1.diff

LOG: Revert "Reapply "[compiler-rt] Default to Lit's Internal Shell""

This reverts commit 225341343f4db6c068c6e4b6848f243dbc1da7b0.

This caused a bunch of buildbot failures:
1. https://lab.llvm.org/buildbot/#/builders/17/builds/12328 - fixed-shadow.c
uses parantheses, almost seems flaky.
2. https://lab.llvm.org/buildbot/#/builders/186/builds/13651 - log-path_test.cpp
is unresolved on some builders.
3. https://lab.llvm.org/buildbot/#/builders/64/builds/6289 - unset is not found
4. https://lab.llvm.org/buildbot/#/builders/42/builds/6809 - ulimit issues
5. https://lab.llvm.org/buildbot/#/builders/169/builds/16628 - flaky JIT failures
that are now a lot more frequent.

Added: 
    

Modified: 
    compiler-rt/test/lit.common.cfg.py

Removed: 
    


################################################################################
diff  --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py
index 1581e4ad15a64..9d2f02189b8bd 100644
--- a/compiler-rt/test/lit.common.cfg.py
+++ b/compiler-rt/test/lit.common.cfg.py
@@ -113,9 +113,6 @@ def push_dynamic_library_lookup_path(config, new_path):
         config.environment[dynamic_library_lookup_var] = new_ld_library_path_64
 
 
-# TODO: Consolidate the logic for turning on the internal shell by default for all LLVM test suites.
-# See https://github.com/llvm/llvm-project/issues/106636 for more details.
-#
 # Choose between lit's internal shell pipeline runner and a real shell.  If
 # LIT_USE_INTERNAL_SHELL is in the environment, we use that as an override.
 use_lit_shell = os.environ.get("LIT_USE_INTERNAL_SHELL")
@@ -123,8 +120,9 @@ def push_dynamic_library_lookup_path(config, new_path):
     # 0 is external, "" is default, and everything else is internal.
     execute_external = use_lit_shell == "0"
 else:
-    # Otherwise we default to internal everywhere.
-    execute_external = False
+    # Otherwise we default to internal on Windows and external elsewhere, as
+    # bash on Windows is usually very slow.
+    execute_external = not sys.platform in ["win32"]
 
 # Allow expanding substitutions that are based on other substitutions
 config.recursiveExpansionLimit = 10