[llvm] Fix/aarch64 memset dup optimization (PR #166030)
via llvm-commits
llvm-commits at lists.llvm.org
Sat Nov 1 16:29:34 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff origin/main HEAD --extensions cpp -- llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp llvm/lib/Target/AArch64/AArch64ISelLowering.cpp --diff_from_common_commit
``````````
:warning:
The reproduction instructions above might return results for more than one PR
in a stack if you are using a stacked PR workflow. You can limit the results by
changing `origin/main` to the base branch/commit you want to compare against.
:warning:
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index d052d1a8b..11ea27d84 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -8543,9 +8543,9 @@ static SDValue getMemsetValue(SDValue Value, EVT VT, SelectionDAG &DAG,
if (!IntVT.isInteger())
IntVT = EVT::getIntegerVT(*DAG.getContext(), IntVT.getSizeInBits());
- // For repeated-byte patterns, generate a vector splat instead of MUL to enable
- // efficient lowering to DUP on targets like AArch64.
- if (NumBits > 8 && VT.isInteger() && !VT.isVector() &&
+ // For repeated-byte patterns, generate a vector splat instead of MUL to
+ // enable efficient lowering to DUP on targets like AArch64.
+ if (NumBits > 8 && VT.isInteger() && !VT.isVector() &&
(NumBits == 32 || NumBits == 64)) {
// Generate a vector of bytes: v4i8 for i32, v8i8 for i64
EVT ByteVecTy = EVT::getVectorVT(*DAG.getContext(), MVT::i8, NumBits / 8);
diff --git a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
index f9e5a706b..ec26e07a2 100644
--- a/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
+++ b/llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
@@ -18342,7 +18342,8 @@ EVT AArch64TargetLowering::getOptimalMemOpType(
Fast;
};
- // For non-zero memset, use NEON even for smaller sizes as dup + scalar store is efficient
+ // For non-zero memset, use NEON even for smaller sizes as dup + scalar store
+ // is efficient
if (CanUseNEON && Op.isMemset() && !IsSmallZeroMemset)
return MVT::v16i8;
if (CanUseFP && !IsSmallZeroMemset &&
``````````
</details>
https://github.com/llvm/llvm-project/pull/166030
More information about the llvm-commits
mailing list