[llvm] 4357fcb - [LegalizeTypes] Use UpdateNodeOperands in SoftPromoteHalfOp_STACKMAP/PATCHPOINT. (#165927)

[via llvm-commits]

Author: Craig Topper
Date: 2025-10-31T23:30:23-07:00
New Revision: 4357fcbbd5012369dbbbe50f99941147895d6611

URL: https://github.com/llvm/llvm-project/commit/4357fcbbd5012369dbbbe50f99941147895d6611
DIFF: https://github.com/llvm/llvm-project/commit/4357fcbbd5012369dbbbe50f99941147895d6611.diff

LOG: [LegalizeTypes] Use UpdateNodeOperands in SoftPromoteHalfOp_STACKMAP/PATCHPOINT. (#165927)

Added: 
    

Modified: 
    llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
index bf1abfe50327e..1178b6fba6f0b 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
@@ -3957,28 +3957,14 @@ SDValue DAGTypeLegalizer::SoftPromoteHalfOp_ATOMIC_STORE(SDNode *N,
 SDValue DAGTypeLegalizer::SoftPromoteHalfOp_STACKMAP(SDNode *N, unsigned OpNo) {
   assert(OpNo > 1); // Because the first two arguments are guaranteed legal.
   SmallVector<SDValue> NewOps(N->ops());
-  SDValue Op = N->getOperand(OpNo);
-  NewOps[OpNo] = GetSoftPromotedHalf(Op);
-  SDValue NewNode =
-      DAG.getNode(N->getOpcode(), SDLoc(N), N->getVTList(), NewOps);
-
-  for (unsigned ResNum = 0; ResNum < N->getNumValues(); ResNum++)
-    ReplaceValueWith(SDValue(N, ResNum), NewNode.getValue(ResNum));
-
-  return SDValue(); // Signal that we replaced the node ourselves.
+  NewOps[OpNo] = GetSoftPromotedHalf(NewOps[OpNo]);
+  return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
 }
 
 SDValue DAGTypeLegalizer::SoftPromoteHalfOp_PATCHPOINT(SDNode *N,
                                                        unsigned OpNo) {
   assert(OpNo >= 7);
   SmallVector<SDValue> NewOps(N->ops());
-  SDValue Op = N->getOperand(OpNo);
-  NewOps[OpNo] = GetSoftPromotedHalf(Op);
-  SDValue NewNode =
-      DAG.getNode(N->getOpcode(), SDLoc(N), N->getVTList(), NewOps);
-
-  for (unsigned ResNum = 0; ResNum < N->getNumValues(); ResNum++)
-    ReplaceValueWith(SDValue(N, ResNum), NewNode.getValue(ResNum));
-
-  return SDValue(); // Signal that we replaced the node ourselves.
+  NewOps[OpNo] = GetSoftPromotedHalf(NewOps[OpNo]);
+  return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
 }