[llvm] [LegalizeTypes] Use UpdateNodeOperands in SoftPromoteHalfOp_STACKMAP/PATCHPOINT. (PR #165927)
Craig Topper via llvm-commits
llvm-commits at lists.llvm.org
Fri Oct 31 14:48:19 PDT 2025
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/165927
None
>From 7c5f2c5b40934411259d28da63bb0b2af26ff673 Mon Sep 17 00:00:00 2001
From: Craig Topper <craig.topper at sifive.com>
Date: Fri, 31 Oct 2025 14:47:04 -0700
Subject: [PATCH] [LegalizeTypes] Use UpdateNodeOperands in
SoftPromoteHalfOp_STACKMAP/PATCHPOINT.
---
.../SelectionDAG/LegalizeFloatTypes.cpp | 22 ++++---------------
1 file changed, 4 insertions(+), 18 deletions(-)
diff --git a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
index bf1abfe50327e..1178b6fba6f0b 100644
--- a/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/LegalizeFloatTypes.cpp
@@ -3957,28 +3957,14 @@ SDValue DAGTypeLegalizer::SoftPromoteHalfOp_ATOMIC_STORE(SDNode *N,
SDValue DAGTypeLegalizer::SoftPromoteHalfOp_STACKMAP(SDNode *N, unsigned OpNo) {
assert(OpNo > 1); // Because the first two arguments are guaranteed legal.
SmallVector<SDValue> NewOps(N->ops());
- SDValue Op = N->getOperand(OpNo);
- NewOps[OpNo] = GetSoftPromotedHalf(Op);
- SDValue NewNode =
- DAG.getNode(N->getOpcode(), SDLoc(N), N->getVTList(), NewOps);
-
- for (unsigned ResNum = 0; ResNum < N->getNumValues(); ResNum++)
- ReplaceValueWith(SDValue(N, ResNum), NewNode.getValue(ResNum));
-
- return SDValue(); // Signal that we replaced the node ourselves.
+ NewOps[OpNo] = GetSoftPromotedHalf(NewOps[OpNo]);
+ return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
}
SDValue DAGTypeLegalizer::SoftPromoteHalfOp_PATCHPOINT(SDNode *N,
unsigned OpNo) {
assert(OpNo >= 7);
SmallVector<SDValue> NewOps(N->ops());
- SDValue Op = N->getOperand(OpNo);
- NewOps[OpNo] = GetSoftPromotedHalf(Op);
- SDValue NewNode =
- DAG.getNode(N->getOpcode(), SDLoc(N), N->getVTList(), NewOps);
-
- for (unsigned ResNum = 0; ResNum < N->getNumValues(); ResNum++)
- ReplaceValueWith(SDValue(N, ResNum), NewNode.getValue(ResNum));
-
- return SDValue(); // Signal that we replaced the node ourselves.
+ NewOps[OpNo] = GetSoftPromotedHalf(NewOps[OpNo]);
+ return SDValue(DAG.UpdateNodeOperands(N, NewOps), 0);
}
More information about the llvm-commits
mailing list