[llvm] [Runtimes][CMake] Add CMake option to enable execute-only code generation on AArch64 (PR #143698)

Petr Hosek via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 31 14:19:36 PDT 2025


=?utf-8?q?Csanád_Hajdú?= <csanad.hajdu at arm.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/143698 at github.com>


petrhosek wrote:

> I really dislike that we're setting `CMAKE_CXX_FLAGS` explicitly here, but that is something we can clean up when we have a better way to share common flags across runtimes.

I agree, we shouldn't be directly modifying `CMAKE_{C,CXX}_FLAGS`, those flags are intended for the user. Instead, we should either set the flags directly on the target with `target_compile_options` or per-directory with `add_compile_options`. In this particular case, it might be possible to simply replace the `set` commands with `add_compile_options`. However, I'd be also fine merging the change as is and cleaning it up in a follow up change.

https://github.com/llvm/llvm-project/pull/143698


More information about the llvm-commits mailing list