[compiler-rt] [TSan][Test-Only][Darwin] Fix typo in external.cpp test (PR #165534)

Dan Blackwell via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 29 02:58:12 PDT 2025


https://github.com/DanBlackwell created https://github.com/llvm/llvm-project/pull/165534

Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the test.

rdar://163398219

>From 15165c5b1b65431380e7ae0a8d13d86dd4f35d22 Mon Sep 17 00:00:00 2001
From: Dan Blackwell <dan_blackwell at apple.com>
Date: Wed, 29 Oct 2025 09:54:03 +0000
Subject: [PATCH] [TSan][Test-Only][Darwin] Fix typo in external.cpp test

Occasionally this test fails in CI. There are two possible races that can occur, one of which is rare. Both are supposed to be handled, but because the test matches "read-only" and the runtime outputs "Read-only" (note the capital letter), the FileCheck fails.

This patch fixes the miscapitalisation of the FileCheck string in the test.
---
 compiler-rt/test/tsan/Darwin/external.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/compiler-rt/test/tsan/Darwin/external.cpp b/compiler-rt/test/tsan/Darwin/external.cpp
index 3869c7abb7664..8372a1eb125f3 100644
--- a/compiler-rt/test/tsan/Darwin/external.cpp
+++ b/compiler-rt/test/tsan/Darwin/external.cpp
@@ -68,9 +68,9 @@ int main(int argc, char *argv[]) {
   // TEST2-NOT: WARNING: ThreadSanitizer
   
   // TEST3: WARNING: ThreadSanitizer: race on MyLibrary::MyObject
-  // TEST3: {{Modifying|read-only}} access of MyLibrary::MyObject at
+  // TEST3: {{Modifying|Read-only}} access of MyLibrary::MyObject at
   // TEST3: {{ObjectWrite|ObjectRead}}
-  // TEST3: Previous {{modifying|read-only}} access of MyLibrary::MyObject at
+  // TEST3: Previous {{modifying|Read-only}} access of MyLibrary::MyObject at
   // TEST3: {{ObjectWrite|ObjectRead}}
   // TEST3: Location is MyLibrary::MyObject of size 16 at
   // TEST3: {{ObjectCreate}}



More information about the llvm-commits mailing list