[llvm] [AArch64][GlobalISel] Add a constant funnel shift post-legalizer combine. (PR #151912)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-lnt` running on `systemz-1` while building `llvm` at step 6 "build stage 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/136/builds/5769

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build stage 1) failure: 'ninja -j4' (failure)
...
[28/273] Building AArch64GenPostLegalizeGILowering.inc...
[29/273] Building AArch64GenSDNodeInfo.inc...
[30/273] Building AArch64GenPreLegalizeGICombiner.inc...
[31/273] Building AArch64GenRegisterBank.inc...
[32/273] Building AArch64GenRegisterInfo.inc...
[33/273] Building CXX object lib/LTO/CMakeFiles/LLVMLTO.dir/LTO.cpp.o
[34/273] Linking CXX static library lib/libLLVMLTO.a
[35/273] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUCombinerHelper.cpp.o
[36/273] Building AArch64GenSubtargetInfo.inc...
[37/194] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPostLegalizerCombiner.cpp.o
FAILED: lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPostLegalizerCombiner.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/include -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPostLegalizerCombiner.cpp.o -MF lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPostLegalizerCombiner.cpp.o.d -o lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPostLegalizerCombiner.cpp.o -c /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp
In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:126:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU/AMDGPUGenPostLegalizeGICombiner.inc: In lambda function:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU/AMDGPUGenPostLegalizeGICombiner.inc:3159: error: no matching function for call to ‘llvm::AMDGPUCombinerHelper::matchOrShiftToFunnelShift(llvm::MachineInstr&, std::function<void(llvm::MachineIRBuilder&)>&)’
 3159 |     if(![&](){return Helper.matchOrShiftToFunnelShift(*State.MIs[0], GIMatchData_info);}()) {
      | 
In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUCombinerHelper.h:20,
                 from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPostLegalizerCombiner.cpp:15:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:643: note: candidate: ‘bool llvm::CombinerHelper::matchOrShiftToFunnelShift(llvm::MachineInstr&, bool, llvm::BuildFnTy&) const’
  643 |   bool matchOrShiftToFunnelShift(MachineInstr &MI, bool AllowScalarConstants,
      | 
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:643: note:   candidate expects 3 arguments, 2 provided
[38/194] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPreLegalizerCombiner.cpp.o
FAILED: lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPreLegalizerCombiner.cpp.o 
CCACHE_CPP2=yes CCACHE_HASHDIR=yes CCACHE_SLOPPINESS=pch_defines,time_macros /usr/bin/ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GLIBCXX_USE_CXX11_ABI=1 -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/include -I/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-array-bounds -Wno-stringop-overread -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fvisibility=hidden  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPreLegalizerCombiner.cpp.o -MF lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPreLegalizerCombiner.cpp.o.d -o lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPUPreLegalizerCombiner.cpp.o -c /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp
In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp:86:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU/AMDGPUGenPreLegalizeGICombiner.inc: In lambda function:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/stage1/lib/Target/AMDGPU/AMDGPUGenPreLegalizeGICombiner.inc:3090: error: no matching function for call to ‘llvm::AMDGPUCombinerHelper::matchOrShiftToFunnelShift(llvm::MachineInstr&, std::function<void(llvm::MachineIRBuilder&)>&) const’
 3090 |     if(![&](){return Helper.matchOrShiftToFunnelShift(*State.MIs[0], GIMatchData_info);}()) {
      | 
In file included from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUCombinerHelper.h:20,
                 from /home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/lib/Target/AMDGPU/AMDGPUPreLegalizerCombiner.cpp:15:
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:643: note: candidate: ‘bool llvm::CombinerHelper::matchOrShiftToFunnelShift(llvm::MachineInstr&, bool, llvm::BuildFnTy&) const’
  643 |   bool matchOrShiftToFunnelShift(MachineInstr &MI, bool AllowScalarConstants,
      | 
/home/uweigand/sandbox/buildbot/clang-s390x-linux-lnt/llvm/llvm/include/llvm/CodeGen/GlobalISel/CombinerHelper.h:643: note:   candidate expects 3 arguments, 2 provided
[39/194] Building CXX object lib/Target/AArch64/CMakeFiles/LLVMAArch64CodeGen.dir/GISel/AArch64O0PreLegalizerCombiner.cpp.o
[40/194] Building CXX object lib/Target/AMDGPU/CMakeFiles/LLVMAMDGPUCodeGen.dir/AMDGPURegBankCombiner.cpp.o
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/151912