[llvm] [CI] fix possibly undefined variable in code-format job (PR #165454)

Baranov Victor via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 28 14:19:00 PDT 2025


https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/165454

>From 2481d965babcd0b80af3d5eefd3219870e55d298 Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Tue, 28 Oct 2025 21:22:09 +0300
Subject: [PATCH 1/2] [CI] fix possibly undefined variable

---
 llvm/utils/git/code-format-helper.py | 1 +
 1 file changed, 1 insertion(+)

diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
index 406a72817acb8..6104429af74ef 100755
--- a/llvm/utils/git/code-format-helper.py
+++ b/llvm/utils/git/code-format-helper.py
@@ -482,6 +482,7 @@ def hook_main():
         args.changed_files.append(line)
 
     failed_fmts = []
+    comments = []
     for fmt in ALL_FORMATTERS:
         if fmt.has_tool():
             if not fmt.run(args.changed_files, args):

>From 54ab31d09f34c1c7a153002bec5ae705af3075af Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Wed, 29 Oct 2025 00:18:46 +0300
Subject: [PATCH 2/2] remove comments

---
 llvm/utils/git/code-format-helper.py | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
index 6104429af74ef..7af1f363e3d0d 100755
--- a/llvm/utils/git/code-format-helper.py
+++ b/llvm/utils/git/code-format-helper.py
@@ -482,13 +482,10 @@ def hook_main():
         args.changed_files.append(line)
 
     failed_fmts = []
-    comments = []
     for fmt in ALL_FORMATTERS:
         if fmt.has_tool():
             if not fmt.run(args.changed_files, args):
                 failed_fmts.append(fmt.name)
-            if fmt.comment:
-                comments.append(fmt.comment)
         else:
             print(f"Couldn't find {fmt.name}, can't check " + fmt.friendly_name.lower())
 



More information about the llvm-commits mailing list