[llvm] [SHT_LLVM_BB_ADDR] Implement ELF and YAML support for Propeller CFG data in PGO analysis map. (PR #164914)

[James Henderson via llvm-commits]

jh7370 wrote:

I don't have any especially major concerns with this. I guess my biggest concern is that I don't think it's right to have references to non-LLVM tools in the LLVM-specific ELF data structures. This is more a naming concern than anything else - if you can come up with a generic name, I'd be less concerned. If we were to allow this change as-is, another tool might come along in the future that uses a similar design but we'd have to rename everything or not realise that there's an opportunity to reuse the field being introduced here.

Furthermore, it would leave us open to the argument that we need to support every tool under the sun that could generate even remotely related data, with its own specific set of fields, which isn't really sustainable. That does raise the question as to whether this approach is the right approach at all and whether instead we should have some sort of generically extendable section that individual tools can leverage. I don't have any concrete ideas here currently though.

https://github.com/llvm/llvm-project/pull/164914