[compiler-rt] Revert "[nsan] More unit tests for `float128`. (#165248)" (PR #165391)
Clement Courbet via llvm-commits
llvm-commits at lists.llvm.org
Tue Oct 28 06:38:08 PDT 2025
https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/165391
This reverts commit 2f869c427b6c800f37147458ac03d1fa6f9ad9d3.
Breaks build on some configurations
>From 06df5cfc6514b2de623f79680459725552f63910 Mon Sep 17 00:00:00 2001
From: Clement Courbet <clement.courbet at gmail.com>
Date: Tue, 28 Oct 2025 14:37:35 +0100
Subject: [PATCH] Revert "[nsan] More unit tests for `float128`. (#165248)"
This reverts commit 2f869c427b6c800f37147458ac03d1fa6f9ad9d3.
---
compiler-rt/lib/nsan/tests/NSanUnitTest.cpp | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp b/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
index 73b59671fe07a..d121292c36682 100644
--- a/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
+++ b/compiler-rt/lib/nsan/tests/NSanUnitTest.cpp
@@ -43,8 +43,8 @@ template <typename FT, auto next> void TestFT() {
ASSERT_EQ(GetULPDiff<FT>(-X, -Y), 3);
// Values with larger differences.
- static constexpr const __uint128_t MantissaSize =
- __uint128_t{1} << FTInfo<FT>::kMantissaBits;
+ static constexpr const __sanitizer::u64 MantissaSize =
+ __sanitizer::u64{1} << FTInfo<FT>::kMantissaBits;
ASSERT_EQ(GetULPDiff<FT>(1.0, next(2.0, 1.0)), MantissaSize - 1);
ASSERT_EQ(GetULPDiff<FT>(1.0, 2.0), MantissaSize);
ASSERT_EQ(GetULPDiff<FT>(1.0, next(2.0, 3.0)), MantissaSize + 1);
@@ -57,6 +57,11 @@ TEST(NSanTest, Double) {
TestFT<double, static_cast<double (*)(double, double)>(nextafter)>();
}
-TEST(NSanTest, Float128) { TestFT<__float128, nextafterf128>(); }
+TEST(NSanTest, Float128) {
+ // Very basic tests. FIXME: improve when we have nextafter<__float128>.
+ ASSERT_EQ(GetULPDiff<__float128>(0.0, 0.0), 0);
+ ASSERT_EQ(GetULPDiff<__float128>(-0.0, 0.0), 0);
+ ASSERT_NE(GetULPDiff<__float128>(-0.01, 0.01), kMaxULPDiff);
+}
} // end namespace __nsan
More information about the llvm-commits
mailing list