[llvm] [SPIRV] Addition of extension SPV_KHR_non_semantic_info (PR #165302)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 27 12:30:06 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {undef deprecator}-->
:warning: undef deprecator found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git diff -U0 --pickaxe-regex -S '([^a-zA-Z0-9#_-]undef([^a-zA-Z0-9_-]|$)|UndefValue::get)' 'HEAD~1' HEAD llvm/test/CodeGen/SPIRV/debug-info/debug-build-identifier-storagepath.ll llvm/test/CodeGen/SPIRV/debug-info/debug-function.ll llvm/test/CodeGen/SPIRV/debug-info/debug-imported-entity.ll llvm/test/CodeGen/SPIRV/debug-info/debug-lexical-scope.ll llvm/test/CodeGen/SPIRV/debug-info/debug-macro-def-undef.ll llvm/test/CodeGen/SPIRV/debug-info/debug-qualifier.ll llvm/test/CodeGen/SPIRV/debug-info/debug-source-continued.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-array.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-composite.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-inheritance.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-ptrtomember.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-template.ll llvm/test/CodeGen/SPIRV/debug-info/debug-typedef.ll llvm/lib/Target/SPIRV/SPIRVEmitNonSemanticDI.cpp llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.h llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp llvm/test/CodeGen/SPIRV/debug-info/debug-type-basic.ll llvm/test/CodeGen/SPIRV/debug-info/debug-type-pointer.ll
``````````
</details>
The following files introduce new uses of undef:
- llvm/test/CodeGen/SPIRV/debug-info/debug-macro-def-undef.ll
[Undef](https://llvm.org/docs/LangRef.html#undefined-values) is now deprecated and should only be used in the rare cases where no replacement is possible. For example, a load of uninitialized memory yields `undef`. You should use `poison` values for placeholders instead.
In tests, avoid using `undef` and having tests that trigger undefined behavior. If you need an operand with some unimportant value, you can add a new argument to the function and use that instead.
For example, this is considered a bad practice:
```llvm
define void @fn() {
...
br i1 undef, ...
}
```
Please use the following instead:
```llvm
define void @fn(i1 %cond) {
...
br i1 %cond, ...
}
```
Please refer to the [Undefined Behavior Manual](https://llvm.org/docs/UndefinedBehavior.html) for more information.
https://github.com/llvm/llvm-project/pull/165302
More information about the llvm-commits
mailing list