[llvm] [test][DebugInfo] Remove unsafe-fp-math uses (NFC) (PR #164966)
Orlando Cazalet-Hyams via llvm-commits
llvm-commits at lists.llvm.org
Mon Oct 27 01:49:14 PDT 2025
https://github.com/OCHyams commented:
I've only scanned but broadly SGTM, we try to suggest that debug info tests have as few as possibly stringy attributes for this reason!
One thing to note, the title says you're removing unsafe-fp-math uses but there's other attributes removed too such as `"disable-tail-calls"="false"`. (Is that the only non-fp attribute that's stripped?).
It'd feel safer (less risk of accidentally introducing a rotten-green test) to only remove the unsafe-fp-math attributes. OTOH, if you would like to proceed with this approach I think the patch title should be updated to reflect that.
Did you use llvm-reduce or some other approach to automatically remove attributes? If so please could you include the methodology in the commit message?
https://github.com/llvm/llvm-project/pull/164966
More information about the llvm-commits
mailing list