[llvm] [MC] Add "override" where appropriate (NFC) (PR #165135)
Kazu Hirata via llvm-commits
llvm-commits at lists.llvm.org
Sat Oct 25 23:27:27 PDT 2025
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/165135
Note that "override" makes "virtual" redundant.
Identified with modernize-use-override.
>From 52027fcdf7df4b49dde538c5a481292d8824ab00 Mon Sep 17 00:00:00 2001
From: Kazu Hirata <kazu at google.com>
Date: Sat, 25 Oct 2025 20:13:20 -0700
Subject: [PATCH] [MC] Add "override" where appropriate (NFC)
Note that "override" makes "virtual" redundant.
Identified with modernize-use-override.
---
llvm/include/llvm/MC/MCDXContainerWriter.h | 2 +-
llvm/include/llvm/MC/MCELFObjectWriter.h | 2 +-
llvm/include/llvm/MC/MCGOFFObjectWriter.h | 2 +-
llvm/include/llvm/MC/MCMachObjectWriter.h | 2 +-
llvm/include/llvm/MC/MCObjectStreamer.h | 2 +-
llvm/include/llvm/MC/MCWasmObjectWriter.h | 2 +-
llvm/include/llvm/MC/MCWinCOFFObjectWriter.h | 2 +-
llvm/lib/MC/GOFFObjectWriter.cpp | 2 +-
llvm/lib/MC/MCAsmStreamer.cpp | 2 +-
llvm/lib/MC/MCParser/AsmParser.cpp | 2 +-
llvm/lib/MC/XCOFFObjectWriter.cpp | 8 ++++----
llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp | 2 +-
llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp | 2 +-
13 files changed, 16 insertions(+), 16 deletions(-)
diff --git a/llvm/include/llvm/MC/MCDXContainerWriter.h b/llvm/include/llvm/MC/MCDXContainerWriter.h
index 44d2af3e8a766..9b6ba896a5f09 100644
--- a/llvm/include/llvm/MC/MCDXContainerWriter.h
+++ b/llvm/include/llvm/MC/MCDXContainerWriter.h
@@ -23,7 +23,7 @@ class MCDXContainerTargetWriter : public MCObjectTargetWriter {
MCDXContainerTargetWriter() {}
public:
- virtual ~MCDXContainerTargetWriter();
+ ~MCDXContainerTargetWriter() override;
Triple::ObjectFormatType getFormat() const override {
return Triple::DXContainer;
diff --git a/llvm/include/llvm/MC/MCELFObjectWriter.h b/llvm/include/llvm/MC/MCELFObjectWriter.h
index a8b00aa2b45ac..35614cb9c9117 100644
--- a/llvm/include/llvm/MC/MCELFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCELFObjectWriter.h
@@ -62,7 +62,7 @@ class MCELFObjectTargetWriter : public MCObjectTargetWriter {
bool HasRelocationAddend_, uint8_t ABIVersion_ = 0);
public:
- virtual ~MCELFObjectTargetWriter() = default;
+ ~MCELFObjectTargetWriter() override = default;
Triple::ObjectFormatType getFormat() const override { return Triple::ELF; }
static bool classof(const MCObjectTargetWriter *W) {
diff --git a/llvm/include/llvm/MC/MCGOFFObjectWriter.h b/llvm/include/llvm/MC/MCGOFFObjectWriter.h
index 78a491522dbd6..ec07637dd2847 100644
--- a/llvm/include/llvm/MC/MCGOFFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCGOFFObjectWriter.h
@@ -21,7 +21,7 @@ class MCGOFFObjectTargetWriter : public MCObjectTargetWriter {
MCGOFFObjectTargetWriter() = default;
public:
- virtual ~MCGOFFObjectTargetWriter() = default;
+ ~MCGOFFObjectTargetWriter() override = default;
Triple::ObjectFormatType getFormat() const override { return Triple::GOFF; }
diff --git a/llvm/include/llvm/MC/MCMachObjectWriter.h b/llvm/include/llvm/MC/MCMachObjectWriter.h
index 41416a2f9c698..2163312b9e3c8 100644
--- a/llvm/include/llvm/MC/MCMachObjectWriter.h
+++ b/llvm/include/llvm/MC/MCMachObjectWriter.h
@@ -48,7 +48,7 @@ class LLVM_ABI MCMachObjectTargetWriter : public MCObjectTargetWriter {
}
public:
- virtual ~MCMachObjectTargetWriter();
+ ~MCMachObjectTargetWriter() override;
Triple::ObjectFormatType getFormat() const override { return Triple::MachO; }
static bool classof(const MCObjectTargetWriter *W) {
diff --git a/llvm/include/llvm/MC/MCObjectStreamer.h b/llvm/include/llvm/MC/MCObjectStreamer.h
index 1899cb6331c6f..d9aecd881b51c 100644
--- a/llvm/include/llvm/MC/MCObjectStreamer.h
+++ b/llvm/include/llvm/MC/MCObjectStreamer.h
@@ -68,7 +68,7 @@ class MCObjectStreamer : public MCStreamer {
MCObjectStreamer(MCContext &Context, std::unique_ptr<MCAsmBackend> TAB,
std::unique_ptr<MCObjectWriter> OW,
std::unique_ptr<MCCodeEmitter> Emitter);
- ~MCObjectStreamer();
+ ~MCObjectStreamer() override;
public:
/// state management
diff --git a/llvm/include/llvm/MC/MCWasmObjectWriter.h b/llvm/include/llvm/MC/MCWasmObjectWriter.h
index 3d5b09407507a..9dd588d0a15b9 100644
--- a/llvm/include/llvm/MC/MCWasmObjectWriter.h
+++ b/llvm/include/llvm/MC/MCWasmObjectWriter.h
@@ -27,7 +27,7 @@ class MCWasmObjectTargetWriter : public MCObjectTargetWriter {
explicit MCWasmObjectTargetWriter(bool Is64Bit_, bool IsEmscripten);
public:
- virtual ~MCWasmObjectTargetWriter();
+ ~MCWasmObjectTargetWriter() override;
Triple::ObjectFormatType getFormat() const override { return Triple::Wasm; }
static bool classof(const MCObjectTargetWriter *W) {
diff --git a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
index b11eacc0dc61d..4a9cf9c56ff01 100644
--- a/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
+++ b/llvm/include/llvm/MC/MCWinCOFFObjectWriter.h
@@ -29,7 +29,7 @@ class MCWinCOFFObjectTargetWriter : public MCObjectTargetWriter {
MCWinCOFFObjectTargetWriter(unsigned Machine_);
public:
- virtual ~MCWinCOFFObjectTargetWriter() = default;
+ ~MCWinCOFFObjectTargetWriter() override = default;
Triple::ObjectFormatType getFormat() const override { return Triple::COFF; }
static bool classof(const MCObjectTargetWriter *W) {
diff --git a/llvm/lib/MC/GOFFObjectWriter.cpp b/llvm/lib/MC/GOFFObjectWriter.cpp
index d68f4af86752f..71bd39763956e 100644
--- a/llvm/lib/MC/GOFFObjectWriter.cpp
+++ b/llvm/lib/MC/GOFFObjectWriter.cpp
@@ -440,7 +440,7 @@ class TextStream : public raw_ostream {
SetBuffer(Buffer, sizeof(Buffer));
}
- ~TextStream() { flush(); }
+ ~TextStream() override { flush(); }
};
} // namespace
diff --git a/llvm/lib/MC/MCAsmStreamer.cpp b/llvm/lib/MC/MCAsmStreamer.cpp
index be8c022f39ad1..885fa55b65d50 100644
--- a/llvm/lib/MC/MCAsmStreamer.cpp
+++ b/llvm/lib/MC/MCAsmStreamer.cpp
@@ -295,7 +295,7 @@ class MCAsmStreamer final : public MCStreamer {
unsigned Flags, unsigned Isa,
unsigned Discriminator, StringRef FileName,
StringRef Location = {}) override;
- virtual void emitDwarfLocLabelDirective(SMLoc Loc, StringRef Name) override;
+ void emitDwarfLocLabelDirective(SMLoc Loc, StringRef Name) override;
MCSymbol *getDwarfLineTableSymbol(unsigned CUID) override;
diff --git a/llvm/lib/MC/MCParser/AsmParser.cpp b/llvm/lib/MC/MCParser/AsmParser.cpp
index acea3ab23680a..dd1bc2be5feb4 100644
--- a/llvm/lib/MC/MCParser/AsmParser.cpp
+++ b/llvm/lib/MC/MCParser/AsmParser.cpp
@@ -726,7 +726,7 @@ class HLASMAsmParser final : public AsmParser {
Lexer.setLexHLASMStrings(true);
}
- ~HLASMAsmParser() { Lexer.setSkipSpace(true); }
+ ~HLASMAsmParser() override { Lexer.setSkipSpace(true); }
bool parseStatement(ParseStatementInfo &Info,
MCAsmParserSemaCallback *SI) override;
diff --git a/llvm/lib/MC/XCOFFObjectWriter.cpp b/llvm/lib/MC/XCOFFObjectWriter.cpp
index fce6b2ac5cf8d..d466009348c47 100644
--- a/llvm/lib/MC/XCOFFObjectWriter.cpp
+++ b/llvm/lib/MC/XCOFFObjectWriter.cpp
@@ -184,7 +184,7 @@ struct CsectSectionEntry : public SectionEntry {
Group->clear();
}
- virtual ~CsectSectionEntry() = default;
+ ~CsectSectionEntry() override = default;
};
struct DwarfSectionEntry : public SectionEntry {
@@ -220,7 +220,7 @@ struct DwarfSectionEntry : public SectionEntry {
DwarfSectionEntry(DwarfSectionEntry &&s) = default;
- virtual ~DwarfSectionEntry() = default;
+ ~DwarfSectionEntry() override = default;
};
struct ExceptionTableEntry {
@@ -249,7 +249,7 @@ struct ExceptionSectionEntry : public SectionEntry {
memcpy(Name, N.data(), N.size());
}
- virtual ~ExceptionSectionEntry() = default;
+ ~ExceptionSectionEntry() override = default;
};
struct CInfoSymInfo {
@@ -276,7 +276,7 @@ struct CInfoSymSectionEntry : public SectionEntry {
std::unique_ptr<CInfoSymInfo> Entry;
CInfoSymSectionEntry(StringRef N, int32_t Flags) : SectionEntry(N, Flags) {}
- virtual ~CInfoSymSectionEntry() = default;
+ ~CInfoSymSectionEntry() override = default;
void addEntry(std::unique_ptr<CInfoSymInfo> NewEntry) {
Entry = std::move(NewEntry);
Entry->Offset = sizeof(uint32_t);
diff --git a/llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp b/llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp
index 01ff1f37f434b..87fad37635320 100644
--- a/llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp
+++ b/llvm/unittests/MC/SystemZ/SystemZMCDisassemblerTest.cpp
@@ -61,7 +61,7 @@ Context &getContext() {
class SystemZMCSymbolizerTest : public MCSymbolizer {
public:
SystemZMCSymbolizerTest(MCContext &MC) : MCSymbolizer(MC, nullptr) {}
- ~SystemZMCSymbolizerTest() {}
+ ~SystemZMCSymbolizerTest() override {}
bool tryAddingSymbolicOperand([[maybe_unused]] MCInst &Inst,
[[maybe_unused]] raw_ostream &CStream,
diff --git a/llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp b/llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp
index 8d4e46c081e19..286528fdd21c3 100644
--- a/llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp
+++ b/llvm/unittests/MC/X86/X86MCDisassemblerTest.cpp
@@ -62,7 +62,7 @@ Context &getContext() {
class X86MCSymbolizerTest : public MCSymbolizer {
public:
X86MCSymbolizerTest(MCContext &MC) : MCSymbolizer(MC, nullptr) {}
- ~X86MCSymbolizerTest() {}
+ ~X86MCSymbolizerTest() override {}
struct OpInfo {
int64_t Value = 0;
More information about the llvm-commits
mailing list