[llvm] Reapply "[ORC] Replace ORC's baked-in dependence ... (#163027)" with … (PR #164340)

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 24 18:55:11 PDT 2025


rupprecht wrote:

> > WDYT?
> 
> We don't want that -- query handlers need to be run outside the session lock.

I didn't think so, but it was worth a shot ;)

> 
> I think we'll just need to filter the `EmitQueries->Updated` list by `Q->IsComplete()` at the end of `IL_emit` just before we return. So that member should become `EmitQueries::CompletedQueries`, and the loop outside can become:
> 
> ```c++
> for (auto &CQ : EmitQueries->CompletedQueries)
>   CQ->handleComplete(*this);
> ```

Created #165063 to do that, and it fixes the tsan issues.

https://github.com/llvm/llvm-project/pull/164340


More information about the llvm-commits mailing list