[llvm] [GitHub][CI] Remove 'Set Safe Directory' step (PR #165052)

Baranov Victor via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 24 15:51:07 PDT 2025


https://github.com/vbvictor created https://github.com/llvm/llvm-project/pull/165052

None

>From 1f2ac51bfa216d76c0e33bf9450fbd13a4ca383a Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Sat, 25 Oct 2025 01:48:41 +0300
Subject: [PATCH 1/2] [GitHub][CI] Remove 'Set Safe Directory' step

---
 .github/workflows/pr-code-format.yml | 8 --------
 .github/workflows/pr-code-lint.yml   | 5 -----
 2 files changed, 13 deletions(-)

diff --git a/.github/workflows/pr-code-format.yml b/.github/workflows/pr-code-format.yml
index 2b85d8b59869c..ac0689b4d3243 100644
--- a/.github/workflows/pr-code-format.yml
+++ b/.github/workflows/pr-code-format.yml
@@ -25,14 +25,6 @@ jobs:
         with:
           fetch-depth: 2
 
-      # We need to set the repo checkout as safe, otherwise tj-actions/changed-files
-      # will fail due to the changed ownership inside the container.
-      # TODO(boomanaiden154): We should probably fix this by having the default user
-      # in the container have the same ID as the GHA user on the host.
-      - name: Set Safe Directory
-        run: |
-          chown -R root $(pwd)
-
       - name: Get changed files
         id: changed-files
         uses: tj-actions/changed-files at ed68ef82c095e0d48ec87eccea555d944a631a4c # v46.0.5
diff --git a/.github/workflows/pr-code-lint.yml b/.github/workflows/pr-code-lint.yml
index e67b518149c2c..8ba9378703739 100644
--- a/.github/workflows/pr-code-lint.yml
+++ b/.github/workflows/pr-code-lint.yml
@@ -31,11 +31,6 @@ jobs:
         with:
           fetch-depth: 2
       
-      # FIXME: same as in ".github/workflows/pr-code-format.yml"
-      - name: Set Safe Directory
-        run: |
-          chown -R root $(pwd)
-      
       - name: Get changed files
         id: changed-files
         uses: tj-actions/changed-files at ed68ef82c095e0d48ec87eccea555d944a631a4c # v46.0.5

>From 8f76f75df0dfe9be69097c877941d711796f3ccc Mon Sep 17 00:00:00 2001
From: Victor Baranov <bar.victor.2002 at gmail.com>
Date: Sat, 25 Oct 2025 01:50:43 +0300
Subject: [PATCH 2/2] test

---
 llvm/utils/git/code-format-helper.py | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/llvm/utils/git/code-format-helper.py b/llvm/utils/git/code-format-helper.py
index 406a72817acb8..46eff86c0fbbe 100755
--- a/llvm/utils/git/code-format-helper.py
+++ b/llvm/utils/git/code-format-helper.py
@@ -282,9 +282,9 @@ class DarkerFormatHelper(FormatHelper):
 
     def _construct_command(self, diff_expression: str | None) -> str:
         darker_cmd = [
-            self.darker_fmt_path,
-            "--check",
-            "--diff",
+        self.darker_fmt_path,
+        "--check",
+        "--diff",
         ]
         if diff_expression:
             darker_cmd += ["-r", diff_expression]



More information about the llvm-commits mailing list