[llvm] [CodeGenPrepare] Don't simplify incomplete expression tree in AddrModeCombine (PR #164628)

[Yingwei Zheng via llvm-commits]

dtcxzyw wrote:

> Does SimplificationTracker still do something useful if the Simplify() part is dropped?
> 
> > Original PR: https://reviews.llvm.org/D36073
> 
> There is some talk about tests in the review discussion, but the actual 400 loc commit does not have even a single test :(

Yeah. It still maintains the set of newly inserted selects/PHI nodes. It also tracks the phi replacement if AddrCombiner finds a match. TBH I believe it needs some refactoring. But I don't like to touch this code :(


https://github.com/llvm/llvm-project/pull/164628