[llvm] Fix build failures related to PR #164551 (PR #164962)

via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 24 08:30:26 PDT 2025


https://github.com/SahilPatidar updated https://github.com/llvm/llvm-project/pull/164962

>From fe09dc281b568c21349d707488c527ad50d7f53a Mon Sep 17 00:00:00 2001
From: SahilPatidar <patidarsahil2001 at gmail.com>
Date: Fri, 24 Oct 2025 17:17:12 +0530
Subject: [PATCH 1/2] Fix build failures related to PR #164551

---
 llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt     |  1 +
 .../ExecutionEngine/Orc/LibraryResolverTest.cpp       | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)

diff --git a/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt b/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
index de6cc8f07fa05..7b563d7bcc68c 100644
--- a/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
+++ b/llvm/unittests/ExecutionEngine/Orc/CMakeLists.txt
@@ -5,6 +5,7 @@ set(LLVM_LINK_COMPONENTS
   IRReader
   JITLink
   Object
+  ObjectYAML
   OrcDebugging
   OrcJIT
   OrcShared
diff --git a/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp b/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
index f6990ee968663..f9396132f19f0 100644
--- a/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
@@ -690,14 +690,21 @@ TEST_F(LibraryResolverIT, PathResolverFollowsSymlinks) {
   // Create a symlink temp -> BaseDir (only if filesystem allows it)
   std::string linkName = BaseDir + withext("/link_to_C");
   std::string target = lib("C");
-  ::symlink(target.c_str(), linkName.c_str());
+
+  if (::symlink(target.c_str(), linkName.c_str()) != 0) {
+    perror("symlink failed");
+    FAIL() << "Failed to create symlink: " << strerror(errno);
+  }
 
   auto resolved = PResolver->resolve(linkName, EC);
   ASSERT_TRUE(resolved.has_value());
   EXPECT_FALSE(EC);
   EXPECT_EQ(*resolved, target);
 
-  ::unlink(linkName.c_str()); // cleanup
+  if (::unlink(linkName.c_str()) != 0) {
+    perror("unlink failed");
+    FAIL() << "Failed to remove symlink: " << strerror(errno);
+  }
 }
 
 TEST_F(LibraryResolverIT, PathResolverCachesResults) {

>From e40b13c015f3659e3bf400e3b2dd6d5b09a62e08 Mon Sep 17 00:00:00 2001
From: SahilPatidar <patidarsahil2001 at gmail.com>
Date: Fri, 24 Oct 2025 21:00:07 +0530
Subject: [PATCH 2/2] Refactor

---
 .../ExecutionEngine/Orc/LibraryResolverTest.cpp       | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp b/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
index f9396132f19f0..f97eadbf89b28 100644
--- a/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
+++ b/llvm/unittests/ExecutionEngine/Orc/LibraryResolverTest.cpp
@@ -691,20 +691,15 @@ TEST_F(LibraryResolverIT, PathResolverFollowsSymlinks) {
   std::string linkName = BaseDir + withext("/link_to_C");
   std::string target = lib("C");
 
-  if (::symlink(target.c_str(), linkName.c_str()) != 0) {
-    perror("symlink failed");
-    FAIL() << "Failed to create symlink: " << strerror(errno);
-  }
+  if (::symlink(target.c_str(), linkName.c_str()) != 0)
+    GTEST_SKIP() << "Failed to create symlink: " << strerror(errno);
 
   auto resolved = PResolver->resolve(linkName, EC);
   ASSERT_TRUE(resolved.has_value());
   EXPECT_FALSE(EC);
   EXPECT_EQ(*resolved, target);
 
-  if (::unlink(linkName.c_str()) != 0) {
-    perror("unlink failed");
-    FAIL() << "Failed to remove symlink: " << strerror(errno);
-  }
+  (void)::unlink(linkName.c_str());
 }
 
 TEST_F(LibraryResolverIT, PathResolverCachesResults) {



More information about the llvm-commits mailing list