[llvm] [X86] Fold generic ADD/SUB with constants to X86ISD::SUB/ADD (PR #164316)

Simon Pilgrim via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 23 03:12:47 PDT 2025


================
@@ -57631,8 +57631,25 @@ static SDValue combineX86AddSub(SDNode *N, SelectionDAG &DAG,
       DCI.CombineTo(GenericAddSub, Op);
     }
   };
-  MatchGeneric(LHS, RHS, false);
-  MatchGeneric(RHS, LHS, X86ISD::SUB == N->getOpcode());
+  MatchGeneric(GenericOpc, LHS, RHS, false);
+  MatchGeneric(GenericOpc, RHS, LHS, X86ISD::SUB == N->getOpcode());
+
+  if (ConstantSDNode *Const = dyn_cast<ConstantSDNode>(RHS)) {
----------------
RKSimon wrote:

(style)
```suggestion
  if (auto *Const = dyn_cast<ConstantSDNode>(RHS)) {
```

https://github.com/llvm/llvm-project/pull/164316


More information about the llvm-commits mailing list