[llvm] [llvm-profgen] Loading binary functions from .symtab when DWARF info is incomplete (PR #163654)
    via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Tue Oct 21 11:02:41 PDT 2025
    
    
  
================
@@ -482,6 +483,10 @@ inline uint64_t SymbolRef::getCommonSize() const {
   return getObject()->getCommonSymbolSize(getRawDataRefImpl());
 }
 
+inline uint64_t SymbolRef::getSize() const {
+  return getObject()->getCommonSymbolSizeImpl(getRawDataRefImpl());
----------------
HighW4y2H3ll wrote:
Ahh, thanks for checking on this! Is this behavior intended for COFF? Because there's another `SymbolRef::getCommonSymbolSize` that does exactly the same thing but with a assertation check: https://github.com/llvm/llvm-project/blob/d4713ecb6dbe2d6b1f586508b47ad9391da51d66/llvm/include/llvm/Object/ObjectFile.h#L314
Would it be better to fix the `SymbolRef` or the COFF `getCommonSymbolSizeImpl` to either get the actual symbol size or return 0?
https://github.com/llvm/llvm-project/pull/163654
    
    
More information about the llvm-commits
mailing list